Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: (CMake) Allow using external abseil-cpp and re2 #4425

Closed
tamaskenez opened this issue Dec 1, 2023 · 0 comments · Fixed by #4426
Closed

[FR]: (CMake) Allow using external abseil-cpp and re2 #4425

tamaskenez opened this issue Dec 1, 2023 · 0 comments · Fixed by #4426
Assignees

Comments

@tamaskenez
Copy link
Contributor

Does the feature exist in the most recent commit?

No.

Why do we need this feature?

When building with CMake, it is not possible to build google test with external abseil-cpp and re2 libraries. Specifying the GTEST_HAS_ABSL=ON expects the abseil and re2 targets to be built by the same project. However, in that case the googletest targets can't be installed since the CMake build system warns that they refer to other targets which aren't installed.

Describe the proposal.

The CMake build script can test if the absl and re2 targets exist. If they don't, invoking find_package for absl and re2 would import the external targets. The Config.cmake.in also needs to be modified to look for absl and re2.

Is the feature specific to an operating system, compiler, or build system version?

It's specific to the CMake build system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants