Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcap WritePacketData copies data unnecessarily #33

Closed
GoogleCodeExporter opened this issue Mar 16, 2015 · 1 comment
Closed

pcap WritePacketData copies data unnecessarily #33

GoogleCodeExporter opened this issue Mar 16, 2015 · 1 comment
Labels
auto-migrated Priority-Medium

Comments

@GoogleCodeExporter
Copy link 

WritePacketData makes a copy of the data with C.CString(string(data)), which is 
expensive and wholly unnecessary.

Patch to fix that is on a branch at 
https://code.google.com/r/matthiasradestock-gopacket-pcap/source/list?name=pcap_
zero_copy_write_packet_data

Original issue reported on code.google.com by matthias...@gmail.com on 6 Aug 2014 at 11:31
@GoogleCodeExporter
Copy link
Author 

Committed in: 
https://code.google.com/p/gopacket/source/detail?r=b7f6fab1f7f56578407345ee0862d
3cb14cd750b

Original comment by gconnell@google.com on 6 Aug 2014 at 11:16

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter