Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate with the test test runner #58

Closed
devoncarew opened this issue Dec 19, 2014 · 3 comments · Fixed by #240
Closed

Integrate with the test test runner #58

devoncarew opened this issue Dec 19, 2014 · 3 comments · Fixed by #240
Milestone
0.7.1

Comments

@devoncarew
Copy link
Contributor

Integrate the Dart Test Runner (https://github.com/google/test_runner.dart) in some way.
@seaneagan
Copy link
Contributor

Updating to reflect that test_runner is being replaced by pub run unittest:unittest.

Grinder already has conveniences to pub global run things, but not to pub run them, see #153, which is what I think we'd want to use here. Ideally, we could just call a dart API instead of pub run, see dart-lang/test#23.

This would also likely deprecate grinder's Tests class, or update its API and impl to match the unittest test runner.

@seaneagan seaneagan changed the title integrate the DTR Integrate with the unittest test runner Mar 30, 2015
@devoncarew
Copy link
Contributor Author

This would also likely deprecate grinder's Tests class, or update its API and impl to match the unittest test runner.

Yeah, we'll want to follow whatever the emerging consensus is.

@devoncarew devoncarew changed the title Integrate with the unittest test runner Integrate with the test test runner Apr 17, 2015
@seaneagan seaneagan added this to the 0.7.1 milestone Apr 17, 2015
@seaneagan seaneagan mentioned this issue Apr 17, 2015
Closed
@devoncarew
Copy link
Contributor Author

test (0.12.0) is out now. For an example of driving it from grinder (w/o a custom wrapper), see #221.

@devoncarew devoncarew mentioned this issue May 18, 2015
Merged
jcollins-g pushed a commit to jcollins-g/grinder.dart that referenced this issue Feb 12, 2021
@munificent
Try to keep function-typed parameters parameter lists with the parame…
b5a0af3 
…ter name.

I can't repro the original issue in google#58, so other nested list changes likely took
care of that, but this addresses the other comments on that bug.

Fixes google#58.

BUG=dart-lang/dart_style#58
R=kevmoo@google.com

Review URL: https://chromiumcodereview.appspot.com//830543002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.1
Development

Successfully merging a pull request may close this issue.

Devoncarew test 0 12 0 google/grinder.dart
2 participants
@seaneagan @devoncarew