Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Capture location] Altitude and accuracy probably not stored in Firebase #2473

Closed
gino-m opened this issue May 15, 2024 · 0 comments · Fixed by #2475
Closed

[Capture location] Altitude and accuracy probably not stored in Firebase #2473

gino-m opened this issue May 15, 2024 · 0 comments · Fixed by #2475
Assignees
Labels
type: bug Something isn't working

Comments

@gino-m
Copy link
Collaborator

gino-m commented May 15, 2024

This code is not reachable:

is CaptureLocationTaskData -> {
CaptureLocationResultConverter.toFirestoreMap(taskData).getOrThrow()
}

...since CaptureLocationTaskData extends GeometryTaskData, which is handled in the previous is statement.

CaptureLocationTaskData doesn't need to extend GeometryTaskData, it can be an independent type with similar fields.

@shobhitagarwal1612 Can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
2 participants