Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically run code checks locally #374

Open
shobhitagarwal1612 opened this issue Feb 18, 2020 · 3 comments
Open

Automatically run code checks locally #374

shobhitagarwal1612 opened this issue Feb 18, 2020 · 3 comments
Labels
help wanted Extra attention is needed type: process Automated builds, test automation, etc.

Comments

@shobhitagarwal1612
Copy link
Member

From comment #370 (review)

  • Run code check on commit instead
  • Realtime warnings in Android Studio (probably by using a plugin)
@shobhitagarwal1612 shobhitagarwal1612 added type: process Automated builds, test automation, etc. priority: p2 labels Feb 18, 2020
@shobhitagarwal1612 shobhitagarwal1612 changed the title [Feature] Description Run code check on git commit Feb 18, 2020
@gino-m
Copy link
Collaborator

gino-m commented Mar 27, 2020

Hi @shobhitagarwal1612! Are we abandoning this one in favor of running checks manually, if I recall? If so we can close it.

@shobhitagarwal1612
Copy link
Member Author

Can we reduce the priority to p3 and mark it has help needed? Let's keep it open so we don't forget about it and re-visit it again sometime in future. Wdyt?

@gino-m gino-m added help wanted Extra attention is needed priority: p3 and removed priority: p2 labels Mar 29, 2020
@gino-m gino-m changed the title Run code check on git commit Automatically run code checks locally Mar 29, 2020
@gino-m
Copy link
Collaborator

gino-m commented Mar 29, 2020

Updated - also updated the description to be more broad, since we're not sure what the best solution is yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed type: process Automated builds, test automation, etc.
Projects
No open projects
Ground
Status: Icebox
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gino-m @shobhitagarwal1612