Exclude field condition

[VladDrake]

https://github.com/google/gson/blob/master/gson/src/main/java/com/google/gson/internal/bind/ReflectiveTypeAdapterFactory.java#L68

Is it ok? If follow that logic, the field going to be excluded when
A. NOT exclude a class
AND
B. NOT exclude a field

I guess it should be return excluder.excludeClass(f.getType(), serialize) || excluder.excludeField(f, serialize)

that means, that, the field going to be excluded when
A. exclude a class
OR
B. exclude a field

Correct me if I wrong

[Marcono1234]

You are right, that does not look correct. It seems the method name is incorrect (should probably be includeField), see its usage below:

gson/gson/src/main/java/com/google/gson/internal/bind/ReflectiveTypeAdapterFactory.java

Lines 153 to 157 in 710a76c

	boolean serialize = excludeField(field, true);
	boolean deserialize = excludeField(field, false);
	if (!serialize && !deserialize) {
	continue;
	}

Changing the implementation of the method causes a lot of test failures because it would erroneously exclude fields then.

---

Note that I am not a member of this project.

[eamonnmcmanus]

Agree with @Marcono1234, I think the two excludeField methods just need to be renamed. Feel free to send a PR.

[Marcono1234]

Maybe the static excludeField can also be removed and the instance method could directly perform the checks. Also it looks like this instance method could be made private.