Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accomodate manually initiated rollbacks #1137

Closed
wants to merge 1 commit into from

Conversation

Vogel612
Copy link
Contributor

When methods marked @transactional initiated a rollback without
throwing an exception, the Interceptor threw an exception with
either "Transaction not active" or "Transaction marked for rollback only"..

Fixes #1136

When methods marked @transactional initiated a rollback without
throwing an exception, the Interceptor threw an exception with
either "Transaction not active" or "Transaction marked for rollback only"..

Fixes google#1136
@Vogel612
Copy link
Contributor Author

Build on jdk7 failed due to a configuration error, while this PR does not touch any CI-related configuration. Could someone please restart the build and check whether the problem is persistent?

@Vogel612
Copy link
Contributor Author

Poking this PR since there recently has been activity on the repository beyond just syncing from internal development. Could I please get some feedback on the state of this PR (and possibly the validity of the issue it's trying to solve?)

@Chris-Lercher
Copy link

We've been eagerly waiting for this to get fixed. As mentioned by the OP, it seems, that the posted commit would work fine, and that the build error was only of temporary nature, completely unrelated to the commit.

This bug is quite serious, as it makes guice-persist virtually unusable if the DB connection is not extremely stable (i.e. in many real world situations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JpaLocalTxnInterceptor incorrectly assumes that @Transactional methods never handle exceptions
3 participants