Is guice project dead?

[iloveeclipse]

I don't see any recent activity on the project, at least not in the public github repo.

I've asked multiple times for a feedback for #1635 but with no reaction.

The last commit 7014486 (created by a bot) approved by a human (@andrewthehan) was on 29 June and that corrected the copyright year.

The last commit crafted by a human (@sameb) e0f1216 was on 22 February.

If this project is not dead, could some human, being left with commit rights on this project, take a look at #1635?

Thank you.

[GedMarc]

It is active - and in use, by everything on google, including google play so....

What happens is the codebase is on their side and the public repo is a copy of it -
Your PR is reviewed internally by the team, and from what I can tell, the request is analyzed and implemented properly or differently to the requests, From what I can tell or seen the testing process across all the products that use it is very intense, usually taking 2/3 days

But once deployed the PR is closed -
There is some bad behaviour where items being reviewed or considered aren't closed once pulled in (hence 325 outstanding) but it's not stopping the development at all

With your PR though, you're altering the binding sequence, it will have massive consequences and there are easily over 200000 apps that must be regression tested with it on the base repo, honestly you should probably just check the sequencing and not build the binders across threads, that's very bad practice

Otherwise, shade and make your changes on your side -
or you can place the updated files into a pr for https://github.com/GedMarc/GuicedEE-Services/tree/master/guice-core and I'll take a look at pulling it into the GuicedEE framework which has a much smaller footprint than the entre of the Google ecosystem ;)

[iloveeclipse]

Your PR is reviewed internally by the team

Would be nice if the team would give a sign of life on the PR.

With your PR though, you're altering the binding sequence, it will have massive consequences and there are easily over 200000 apps that must be regression tested with it on the base repo

Good to know someone tests things too.

honestly you should probably just check the sequencing

Would be great if you would give us some hint on the PR what direction the fix should go.

and not build the binders across threads, that's very bad practice

Are we talking about same PR? Do you mean our application or the proposed fix in #1635?

Anyway, thanks for the feedback, the question here is answered and I would be glad to continue discussion with a real human on the PR #1635.