Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binder.install() should possibly be safe from RuntimeExceptions #33

Closed
gissuebot opened this issue Jul 7, 2014 · 7 comments
Closed

Comments

@gissuebot
Copy link

From kevinb9n on February 27, 2007 02:59:57

if anything is thrown out of Module.configure(), the binder might want to
catch that and record it with addError() instead of bombing out completely.
 However, this may not be so great either as there could be a ripple effect
of other errors that happen only because of the missing bindings from this
module.

Original issue: http://code.google.com/p/google-guice/issues/detail?id=33

@gissuebot
Copy link
Author

From kevinb9n on February 27, 2007 00:04:42

(No comment was entered for this change.)

Labels: -Type-Defect -Priority-Medium Type-Enhancement Priority-Low

@gissuebot
Copy link
Author

From kevinb9n on March 12, 2007 18:13:31

(No comment was entered for this change.)

Labels: 1.1

@gissuebot
Copy link
Author

From kevinb9n on March 19, 2007 11:13:05

some concern about collateral errors if we continue.  But... is it worse to show
people errors that aren't really errors, or to not show them errors that really are?
 Everyone is well accustomed to collateral damage from javac, their junit tests, etc.

@gissuebot
Copy link
Author

From bslesinsky on July 07, 2007 17:17:33

Presumably some errors can be reporting even assuming that there are more modules to
add that we don't know about (open-world) while others assume we have all the
information (closed world).  If an module bombs out, it seems like we should still go
on and do error-checking under the open-world assumption.

If there were a way to do this, we could also check subsets of modules for
consistency; that is, check whether any single module is self-consistent, or whether
any two modules are compatible.

@gissuebot
Copy link
Author

From limpbizkit on May 29, 2008 23:52:46

(No comment was entered for this change.)

Labels: -1.1 Milestone-Release2.0

@gissuebot
Copy link
Author

From limpbizkit on June 24, 2008 23:38:03

We can simply call binder.addError() if installing a Module bombs out.

@gissuebot
Copy link
Author

From limpbizkit on July 07, 2008 17:27:30

Jacob Hite submitted a fix. Thanks!

Status: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant