Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beef up write syscall tests #2370

Open
fvoznika opened this issue Apr 8, 2020 · 1 comment
Open

Beef up write syscall tests #2370

fvoznika opened this issue Apr 8, 2020 · 1 comment
Labels
area: filesystem Issue related to filesystem area: tests Issue related to tests good first issue Good for newcomers type: cleanup Refactorings and cleanups to improve the code

Comments

@fvoznika
Copy link
Member

fvoznika commented Apr 8, 2020

There are only a few basic syscall tests for write(2) and pwrite(2). Here is an incomplete list of missing tests:

  • bad buffer states (EFAULT).
  • bad fds (wrong permission, wrong type of file, EBADF).
  • check offset is incremented.
  • check for EOF.
  • writing to pipes, symlinks, special files.
@fvoznika fvoznika added good first issue Good for newcomers type: cleanup Refactorings and cleanups to improve the code area: tests Issue related to tests area: filesystem Issue related to filesystem labels Apr 8, 2020
@dragoneena12 dragoneena12 mentioned this issue Jun 16, 2020
Closed
@avagin avagin added kokoro:run Presubmits may be run and removed kokoro:run Presubmits may be run labels Jun 25, 2020
@github-actions
Copy link

A friendly reminder that this issue had no activity for 120 days.

@github-actions github-actions bot added stale-issue This issue has not been updated in 120 days. and removed stale-issue This issue has not been updated in 120 days. labels Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: filesystem Issue related to filesystem area: tests Issue related to tests good first issue Good for newcomers type: cleanup Refactorings and cleanups to improve the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@avagin @fvoznika