Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use PR labels to indicate final merge status #107

Closed
asraa opened this issue Aug 17, 2023 · 1 comment
Closed

chore: use PR labels to indicate final merge status #107

asraa opened this issue Aug 17, 2023 · 1 comment

Comments

@asraa
Copy link
Collaborator

asraa commented Aug 17, 2023

Because of internal requirements, we require that PRs be squashed into a single commit before being merged. Currently, this is implemented with a pr_style workflow that checks the number of commits. However, enforcing this during the review process makes it difficult to see changes after comments are addressed.

Instead, we may want to allow the author to keep multiple commits (and potentially disallow merge commits to make this easier), and simply require a squash at the end of the review process.

@AlexanderViand-Intel
Copy link
Collaborator

Closing, as this seems to have been achieved with the current workflow (c.f. https://google.github.io/heir/docs/contributing/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants