Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique names for TypeConverters generated by the template generator #482

Closed
j2kun opened this issue Mar 5, 2024 · 0 comments · Fixed by #483
Closed

Add unique names for TypeConverters generated by the template generator #482

j2kun opened this issue Mar 5, 2024 · 0 comments · Fixed by #483
Assignees
Labels
bug Something isn't working

Comments

@j2kun
Copy link
Collaborator

j2kun commented Mar 5, 2024

The type converter name is PassTypeConverter, but if multiple conversion passes use the same name, they will silently overwrite each other (thanks C++). Let's give them all unique names in the template generator based on the name of the pass.

Could also do an anonymous inner namespace, but I prefer unique names for the grep test.

@j2kun j2kun added the bug Something isn't working label Mar 5, 2024
@j2kun j2kun self-assigned this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant