Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine if AlignRotations pattern needs more complex patterns #514

Open
j2kun opened this issue Mar 11, 2024 · 2 comments
Open

Determine if AlignRotations pattern needs more complex patterns #514

j2kun opened this issue Mar 11, 2024 · 2 comments
Labels
dialect: tensor_ext Issues concerning the tensor_ext dialect

Comments

@j2kun
Copy link
Collaborator

j2kun commented Mar 11, 2024

Currently it matches against (OpA (rotate...) (OpB (rotate...) (rotate...))) and (OpA (OpB (rotate...) (rotate...)) (rotate...)), should it also handle (OpA (OpB (rotate...) (rotate...)) (OpC (rotate...) (rotate...)))
@j2kun j2kun added the dialect: tensor_ext Issues concerning the tensor_ext dialect label Mar 11, 2024
@j2kun j2kun mentioned this issue Mar 11, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2024 •
edited

This issue has 1 outstanding TODOs:

This comment was autogenerated by todo-backlinks

@j2kun
Copy link
Collaborator Author

j2kun commented Mar 11, 2024

Part of #475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dialect: tensor_ext Issues concerning the tensor_ext dialect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@j2kun