-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot build with bazel #25
Comments
Hi Vinzent, that's correct, the real problem is the lack of "manual" tag. I've added it, so that test target should no longer be built unless manually specified. Thanks for reporting, and please let me know if that doesn't solve it for you :) |
Thanks for the fix, now I'm getting this error:
|
Thanks for bringing this up. Looks like Bazel has changed its behavior, this was previously allowed. Some questions for you: would it be troublesome if we changed the paths to I'm trying to keep the github/internal versions in sync without conversions in either direction, but it is getting a bit difficult :) |
About your questions:
Maybe the best path forward is to use the Bazel file only internally at Google and maintain only the Makefile for the public version of highwayhash? |
With #26 I no longer need Bazel for the Rust bindings. |
Thank you for the Makefile update :) The include path changes and a few other fixes are coming soon. |
I'm getting this error when trying to compile highwayhash with bazel:
Maybe
base
is something internal at Google?The text was updated successfully, but these errors were encountered: