Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highwayhash on PPC #74

Closed
vaibhavsood opened this issue Oct 3, 2018 · 1 comment
Closed

Highwayhash on PPC #74

vaibhavsood opened this issue Oct 3, 2018 · 1 comment

Comments

@vaibhavsood
Copy link

vaibhavsood commented Oct 3, 2018

Hi,

I am looking at the PPC implementation https://github.com/google/highwayhash/blob/master/highwayhash/hh_vsx.h

My query is if this implementation can be optimized further by completely implementing in assembly?

There is a minio implementation of Highwayhash for Intel all in assembly https://github.com/minio/highwayhash/blob/master/highwayhashAVX2_amd64.s, what i wanted an opinion on was if converting this file to PPC (a pure assembly implemention) will be a faster version as compared to using the .c/.h VSX files in this repo? @jan-wassenberg

@jan-wassenberg
Copy link
Member

Hi, it's an interesting question. I find that clang translates x86 intrinsics quite well, such that assembly isn't a big win. Not sure how the situation is on POWER, I haven't looked at the assembly there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants