Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Time/Date Pickers, use the Button to step through the columns before it becomes a 'commit' #160

Closed
BowerSteve opened this issue May 13, 2022 · 6 comments
Labels
Blocked Compose Compose related (layout, composables)

Comments

@BowerSteve
Copy link
Collaborator

I think it would be good for the Button on the multi-picker screens to step through the pickers. For example, start on Day and offer '>', and clicking takes you to the Month (stays as a '>'), then when you click onto the Year, it changes to the Check icon and commits the choice.

@yschimke yschimke added the Compose Compose related (layout, composables) label Jul 20, 2022
@MohitMandalia
Copy link
Contributor

Hi @yschimke is this something to be picked up?

It would look something like this, when user clicks it moves forward and if user turns back by clicking on date or any other control it again changes to >, let me know if this is something to be done.

Thanks

Screenshot 2022-09-30 at 8 01 48 AM

@yschimke
Copy link
Collaborator

I'll check if we have an existing figma for this, but essentially yes.

@MohitMandalia
Copy link
Contributor

I'll check if we have an existing figma for this, but essentially yes.

Sure please check and let me know I'll raise a PR if its okay.

@yschimke
Copy link
Collaborator

yschimke commented Oct 3, 2022

@MohitMandalia I checked, we do have Figma, but internally we also have an implementation of this, so we will likely just refresh the implementation here from the internal one. So no sense, tackling again.

@MohitMandalia
Copy link
Contributor

Hmm so I guess no input is needed here from my end @yschimke

@yschimke
Copy link
Collaborator

yschimke commented Mar 13, 2023

Out of date given recent changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Compose Compose related (layout, composables)
Projects
None yet
Development

No branches or pull requests

4 participants