Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check icon size #1797

Closed
yschimke opened this issue Nov 9, 2023 · 3 comments
Closed

Check icon size #1797

yschimke opened this issue Nov 9, 2023 · 3 comments
Assignees
@yschimke

Comments

@yschimke
Copy link
Collaborator

yschimke commented Nov 9, 2023 

          The icon size has increased. Based on the code changes in this PR, I'm assuming it's only a side effect in the screenshots and not when running the app?

Originally posted by @luizgrp in #1795 (comment)
@yschimke yschimke self-assigned this Nov 9, 2023
@yschimke
Copy link
Collaborator Author

yschimke commented Nov 10, 2023 •
edited
Loading

They match how they render on device, so perhaps it's that previous issue with sloppy tolerances, and they changed a long time ago?

image

@yschimke yschimke reopened this Nov 10, 2023
@yschimke
Copy link
Collaborator Author

yschimke commented Nov 10, 2023 •
edited
Loading

It is target sdk or robolectric related.

@Config(
    sdk = [33]

Are you ok with it? Or do you want to apply some other change.

@luizgrp
Copy link
Member

luizgrp commented Nov 10, 2023

Ah we are using a drawable from the sdk in that particular test (android.R.drawable.sym_def_app_icon) so it seems to be sensitive to the target sdk. I'm happy to close it, thanks for checking it!

@luizgrp luizgrp closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yschimke yschimke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yschimke @luizgrp