Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilities for round device padding #191

Closed
yschimke opened this issue May 20, 2022 · 6 comments
Closed

Utilities for round device padding #191

yschimke opened this issue May 20, 2022 · 6 comments
Labels
Compose Compose related (layout, composables) Feature Request

Comments

@yschimke
Copy link
Collaborator

For example Modifier.roundDevicePadding(width = 1f). This is sometimes neccesary to add to the final item to ensure it can be scrolled high enough to be not cutoff.

See this clumsy fix https://github.com/joreilly/PeopleInSpace/pull/131/files

Similar to API at https://google.github.io/accompanist/insets/ for insets.

@yschimke
Copy link
Collaborator Author

cc @saryongkang

@saryongkang
Copy link
Collaborator

Got it. I'm gonna start for it next Thu (June 26). ;)

@yschimke yschimke removed the good first issue Good for newcomers label Jul 10, 2022
@yschimke yschimke added the Compose Compose related (layout, composables) label Jul 20, 2022
@oas004
Copy link
Contributor

oas004 commented Sep 18, 2022

Is this being worked on by any chance? 😄 Is this something you would like to have in /compose-tools? :)

@yschimke
Copy link
Collaborator Author

compose-tools is more previews and testing tools.

Probably compose-layout. I don't think we have a clear API in mind yet. I'm a bit wary if we don't have someone screaming for it, and ready to use it.

We should have some sample ideas in mind, such as ensuring the final item in a list is high enough to not be cutoff on the sides. Or maybe something in between fillMaxSize and fillMaxRectangle?

@oas004
Copy link
Contributor

oas004 commented Sep 19, 2022

compose-tools is more previews and testing tools.

Probably compose-layout. I don't think we have a clear API in mind yet. I'm a bit wary if we don't have someone screaming for it, and ready to use it.

We should have some sample ideas in mind, such as ensuring the final item in a list is high enough to not be cutoff on the sides. Or maybe something in between fillMaxSize and fillMaxRectangle?

That makes sense!😊 I think ensuring the final item is high enough to not be cut off is a nice idea😊

@yschimke
Copy link
Collaborator Author

Out of scope for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compose Compose related (layout, composables) Feature Request
Projects
None yet
Development

No branches or pull requests

3 participants