Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change UI State concept of player #288

Closed
yschimke opened this issue Jun 28, 2022 · 1 comment
Closed

Change UI State concept of player #288

yschimke opened this issue Jun 28, 2022 · 1 comment
Labels
Media UI Media UI related

Comments

@yschimke
Copy link
Collaborator

yschimke commented Jun 28, 2022 •
edited
Loading

See #286 (comment)

given the UI layer has its own model PlayerUiState, it could be changed to attend the specific needs of the UI classes, e.g. playerUiState.loading instead of playerUiState.connected; or playerUiState.mediaDisplayStatus be either of values Loading, Playing or NotPlaying.

Use modes like playing, loading etc.
@yschimke yschimke self-assigned this Jun 28, 2022
@yschimke yschimke changed the title Change UI State of player Change UI State concept of player Jun 28, 2022
@yschimke yschimke added the Media UI Media UI related label Jul 20, 2022
@yschimke yschimke removed their assignment Feb 7, 2023
@yschimke
Copy link
Collaborator Author

Fixed via other changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Media UI Media UI related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yschimke