Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Can't find BaseHoverMenuAdapter #52

Closed
AhmedMourad0 opened this issue Jun 5, 2017 · 8 comments
Closed

Can't find BaseHoverMenuAdapter #52

AhmedMourad0 opened this issue Jun 5, 2017 · 8 comments

Comments

@AhmedMourad0
Copy link

Hey there, i'm trying to implement your awesome library into my app but i can't seem to find the BaseHoverMenuAdapter superclass, is it based on an older version or am i missing something?

Thanks

image

@matthew-carroll
Copy link
Contributor

Hi, that should probably read "implements HoverMenuAdapter" instead of "extends BaseHoverMenuAdapter". If you implement the HoverMenuAdapter interface then you should be good to do.

@AhmedMourad0
Copy link
Author

yup, that worked, it's working splendidly thanks for the awesome library

@AhmedMourad0
Copy link
Author

btw, is there a way to change the color of the little cursor at the top?

image

@AhmedMourad0
Copy link
Author

AhmedMourad0 commented Jun 6, 2017

i think this line is supposed to be the one to set it (HoverMenuContentView --> line 149)

image

but i can't seem to find out how to reach it when i'm using my own service (just like the example hoverdemo), nor can i find the method to collapse the view actually

@matthew-carroll
Copy link
Contributor

Yeah it looks like the expand/collapse is missing from the Service. I should have added a way to get the HoverMenuView from the Service so you could adjust these details. Worst case scenario you could implement your own version of that Service and you'll be able to call any method on the menu.

I've got a major refactor of Hover coming up in the next few weeks. I'll try to get these discrepancies worked out.

@AhmedMourad0
Copy link
Author

got it, thanks again, can't wait for the next refactor Good luck!

@silin
Copy link

silin commented Jun 8, 2017

Looks like README should be updated with implements wording
Plus there is no BaseHoverMenuAdapter in version 0.9.7

@matthew-carroll
Copy link
Contributor

Note: 0.9.8 was just released. It has many breaking changes, but it should allow for both of the goals discussed in this thread.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants