Util.fromHex() fails to reject invalid hex characters #67
Comments
15characterlimi
added a commit
to 15characterlimi/identity-credential
that referenced
this issue
Jun 4, 2022
This is because Character.digit('X', 16) returns -1 rather than throwing.
This commit changes the behavior to throw instead, by building on top of Integer.parseInt(). Note that Byte.parseByte() wouldn't work because it doesn't accept unsigned values >= 0x80.
While I was add it, I tweaked the check for odd numbers to be (what I consider) more idiomatic, and quote the offending length.
This commit fixes openwallet-foundation-labs#67
15characterlimi
added a commit
to 15characterlimi/identity-credential
that referenced
this issue
Jun 4, 2022
This is because Character.digit('X', 16) returns -1 rather than throwing.
This commit changes the behavior to throw instead, by building on top of Integer.parseInt(). Note that Byte.parseByte() wouldn't work because it doesn't accept unsigned values >= 0x80.
While I was add it, I tweaked the check for odd numbers to be (what I consider) more idiomatic, and quote the offending length.
This commit fixes openwallet-foundation-labs#67
15characterlimi
added a commit
to 15characterlimi/identity-credential
that referenced
this issue
Jun 8, 2022
This is because Character.digit('X', 16) returns -1 rather than throwing.
This commit changes the behavior to throw instead, by building on top of Integer.parseInt(). Note that Byte.parseByte() wouldn't work because it doesn't accept unsigned values >= 0x80.
While I was add it, I tweaked the check for odd numbers to be (what I consider) more idiomatic, and quote the offending length.
This commit fixes openwallet-foundation-labs#67
15characterlimi
added a commit
to 15characterlimi/identity-credential
that referenced
this issue
Jun 8, 2022
This is because Character.digit('X', 16) returns -1 rather than throwing.
This commit changes the behavior to throw instead, by building on top of Integer.parseInt(). Note that Byte.parseByte() wouldn't work because it doesn't accept unsigned values >= 0x80.
While I was add it, I tweaked the check for odd numbers to be (what I consider) more idiomatic, and quote the offending length.
This commit fixes openwallet-foundation-labs#67
sethmoo
pushed a commit
that referenced
this issue
Jun 9, 2022
This is because Character.digit('X', 16) returns -1 rather than throwing.
This commit changes the behavior to throw instead, by building on top of Integer.parseInt(). Note that Byte.parseByte() wouldn't work because it doesn't accept unsigned values >= 0x80.
While I was add it, I tweaked the check for odd numbers to be (what I consider) more idiomatic, and quote the offending length.
This commit fixes #67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
Util.fromHex("XX") throws IllegalArgumentException
Actual Behavior
Util.fromHex("XX") returns -17 (= 0xEF)
This is because Util.fromHex() is built on top of Character.digit(), and Character.digit('X', 16) returns -1.
I already have a commit to fix this, I'm just filing this issue first so I can reference it from my fix commit.
The text was updated successfully, but these errors were encountered: