Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module recorded as "unreadable" when one of its direct dependencies is unloadable #37

Closed
rchen152 opened this issue Dec 14, 2018 · 0 comments
Assignees

Comments

@rchen152
Copy link
Contributor

Reproduce with:

git clone git@github.com:GoogleCloudPlatform/django-cloud-deploy.git
cd django-cloud-deploy
pip install .
importlab --tree django-cloud-deploy/cloudlib/database.py

importlab reports:

Reading 1 files
Source tree:

Unreadable files:
  /usr/local/google/home/rechen/django-cloud-deploy/django_cloud_deploy/cloudlib/database.py

In fact, database.py is readable, but a file in one of its pip-installed dependencies (django/contrib/auth/models.py) throws an error at import time.

  • importlab should mark models.py instead of database.py as unreadable.
  • It would be useful to surface the actual error that occurred, to give the user a better idea of why the file is unreadable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant