Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance Advice] key parameter for text() function #488

Open
ghost opened this issue Oct 21, 2022 · 0 comments
Open

[Performance Advice] key parameter for text() function #488

ghost opened this issue Oct 21, 2022 · 0 comments

Comments

@ghost
Copy link

ghost commented Oct 21, 2022

Overview

This is a recommendation and discussion for implementing a key parameter for the ID.text() function. The reason why I am recommending that is because there can be performance losses when using for or if statements directly on text nodes because the library's "reconciliation" algorithm may not know which text nodes were added, removed, or shuffled.

Possible changes

Instead of text(value, ...formatters), the text() function could have the following signature:

text(value, key = null, ...formatters)

I hope this advice helps incremental-dom with a performance boost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants