Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Fixing issue: "Error:(20,0) No such property. model for class". Updated Travis config and Gradle files #165

Closed
wants to merge 9 commits into from

Conversation

piotrek1543
Copy link

Hi, I deleted signingConfings. It makes an error on first build after cloning repository and moreover, I don't feel it is necessary for this app which would it be rather used for testing, discovering new things, learning to code from the best.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@piotrek1543
Copy link
Author

I signed it!

@ardock
Copy link
Contributor

ardock commented Oct 26, 2015

Your first build failed due you didn't follow the step 6 of the building instructions:

6 . Add your debug keystore to the project (save it as android/debug.keystore), or modify the build.gradle file to point to your key.

Your pull request failed due an outdated travis-ci configuration and my pending pull request fixes it and depends on the part you try to remove.

I know they don't use it internally and no need our contributions, they only share the source as a sample, but would be nice that our pull requests could be automatically checked.

@piotrek1543 piotrek1543 changed the title Deleting signingConfigs.debug from app build.gradle. Deleting signingConfigs.debug and fixing issue: "No such property. model for class: org.gradle.plugins.ide.eclipse.EclipsePlugin" Oct 29, 2015
@piotrek1543 piotrek1543 changed the title Deleting signingConfigs.debug and fixing issue: "No such property. model for class: org.gradle.plugins.ide.eclipse.EclipsePlugin" Deleting signingConfigs.debug and fixing issue: "Error:(20,0) No such property. model for class" Oct 29, 2015
@piotrek1543
Copy link
Author

I signed it!

@ardock
Copy link
Contributor

ardock commented Nov 3, 2015

Hi, I deleted signingConfings.

Why?

I don't feel it is necessary...

I do.

Did you set up the server side?

@piotrek1543
Copy link
Author

Well, I need an iosched version, which I can run on my prepared emulator for without Google account like Genymotion. Server side depends on Google services, so I can't run it on "phone" without them.

@ardock, if you could help me resolve this problem, I would be glad. I need this app only for testing and learn some things like material-design-driven app development.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Nov 3, 2015
@eneim
Copy link

eneim commented Nov 3, 2015

I think he (@ardock) meant that the signConfig was there by purpose, and it was an important part of this project where you should not delete. In fact, you should and definitely should keep it and modify that part in case you want to create your own Conference Helper Client (an adoption of this Project). So take care of your signing config.

@eneim
Copy link

eneim commented Nov 3, 2015

@piotrek1543 I update my answer. The point is @ardock doesn't encourage you to remove the signConfig in the project.

@piotrek1543 piotrek1543 changed the title Deleting signingConfigs.debug and fixing issue: "Error:(20,0) No such property. model for class" Fixing issue: "Error:(20,0) No such property. model for class" Nov 3, 2015
@piotrek1543 piotrek1543 changed the title Fixing issue: "Error:(20,0) No such property. model for class" Fixing issue: "Error:(20,0) No such property. model for class". Updated Travis config Nov 3, 2015
@piotrek1543
Copy link
Author

@eneim @ardock Ok, I returned deleted statements and changed name of pull request

@piotrek1543
Copy link
Author

I also updated Gradle files. Hope you enjoy this.

@piotrek1543 piotrek1543 changed the title Fixing issue: "Error:(20,0) No such property. model for class". Updated Travis config Fixing issue: "Error:(20,0) No such property. model for class". Updated Travis config and Gradle files Nov 3, 2015
@ardock
Copy link
Contributor

ardock commented Nov 4, 2015

Thanks @eneim, that was my opinion. 3000+ forks, we can do this type of changes in our forks.
Sorry @piotrek1543, I never used Genymotion but searching this on Google, first two results seem useful:

Genymotion. Server side depends on Google services
How to install Google Play Services on Genymotion Step by Step
Google Play Services in Genymotion on Lollipop (Android 5.0)

@piotrek1543
Copy link
Author

@ardock, thanks for your help. I noticed that this app wouldn't work without Google account and that was the main idea to change it. Change it to run on an Android emulator or GApps-free device.

Now (I mean: after your help) I'm closing this pull request as not solved.

@piotrek1543 piotrek1543 closed this Nov 4, 2015
@ardock
Copy link
Contributor

ardock commented Nov 4, 2015

@piotrek1543 You are welcome, and sorry about that, I didn't understand the change and I'm not fluent in English, good luck Eneim translates me :).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants