Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable MLIR crash reproducer on CI in python tests. #3943

Merged
merged 4 commits into from Nov 22, 2020
Merged

Disable MLIR crash reproducer on CI in python tests. #3943

merged 4 commits into from Nov 22, 2020

Conversation

ScottTodd
Copy link
Collaborator

We aren't uploading reproducer artifacts anywhere, and using the crash reproducer suppresses C++ stack traces. By disabling the reproducer on CI we should get more helpful error logs when the compiler crashes. As before, developers can run tests locally to generate reproducer artifacts.

@google-cla google-cla bot added the cla: yes label Nov 20, 2020
@ScottTodd
Copy link
Collaborator Author

https://source.cloud.google.com/results/invocations/632c178d-f42a-4cc9-abd2-ced892daeed9/targets/iree%2Fgcp_ubuntu%2Fbazel%2Flinux%2Fx86-swiftshader%2Fintegrations%2Fpresubmit/log

absl.flags._exceptions.UnrecognizedFlagError: Unknown command line flag 'use_crash_reproducer'

Figured as much :P @phoenix-meadowlark

@phoenix-meadowlark
Copy link
Contributor

https://source.cloud.google.com/results/invocations/632c178d-f42a-4cc9-abd2-ced892daeed9/targets/iree%2Fgcp_ubuntu%2Fbazel%2Flinux%2Fx86-swiftshader%2Fintegrations%2Fpresubmit/log

absl.flags._exceptions.UnrecognizedFlagError: Unknown command line flag 'use_crash_reproducer'

Figured as much :P @phoenix-meadowlark

We could condition this on bazel test vs bazel run. We're squirreling away the artifacts when we run bazel test anyway, so if you add something like

def _running_bazel_test() -> bool:
  return "TEST_TMPDIR" in os.environ

# FLAGS.use_crash_reproducer defaults to True
use_crash_reproducer = FLAGS.use_crash_reproducer and not _running_bazel_test()

that wouldn't interrupt too many people's work flows. Hopefully there's a better way of determining if bazel test is running, but TEST_TMPDIR won't lead to any false negatives.

@ScottTodd
Copy link
Collaborator Author

https://source.cloud.google.com/results/invocations/632c178d-f42a-4cc9-abd2-ced892daeed9/targets/iree%2Fgcp_ubuntu%2Fbazel%2Flinux%2Fx86-swiftshader%2Fintegrations%2Fpresubmit/log

absl.flags._exceptions.UnrecognizedFlagError: Unknown command line flag 'use_crash_reproducer'

Figured as much :P @phoenix-meadowlark

We could condition this on bazel test vs bazel run. We're squirreling away the artifacts when we run bazel test anyway, so if you add something like

def _running_bazel_test() -> bool:
  return "TEST_TMPDIR" in os.environ

# FLAGS.use_crash_reproducer defaults to True
use_crash_reproducer = FLAGS.use_crash_reproducer and not _running_bazel_test()

that wouldn't interrupt too many people's work flows. Hopefully there's a better way of determining if bazel test is running, but TEST_TMPDIR won't lead to any false negatives.

Works for me. Let's see if the CI is happy :)

@ScottTodd ScottTodd marked this pull request as ready for review November 21, 2020 00:00
@benvanik @phoenix-meadowlark
Update integrations/tensorflow/bindings/python/pyiree/tf/support/modu…
f79d15b 
…le_utils.py

Co-authored-by: Phoenix Meadowlark <meadowlark@google.com>
@benvanik benvanik merged commit 7f989eb into iree-org:main Nov 22, 2020
This was referenced Nov 23, 2020
Closed
Merged
@ScottTodd ScottTodd deleted the crash-reproducer branch November 30, 2020 15:59
iree-copybara-bot pushed a commit that referenced this pull request Nov 30, 2020
@rsuderman @ScottTodd
Merge main -> google
7c335bd 
* f92602b Always emitting framepointers in generated ELFs (#3987)
* 89ef632 bump Tracy to get Android fixes (#3988)
* 7f989eb Disable MLIR crash reproducer on CI in python tests. (#3943)
* 4db3d08 Adding a demonstration of using the flow dialect post-partitioning. (#3701)
* 589dfa7 Remove no-longer-functional flag (#3961)
* 6454317 Fix MacOS builds after hack-and-slash PR (#3962)
* 8fb887e Update links to coverage tables (#3956)
* c93facb Adding iree_atomic_slist_t type. (#3917)
* bd082ca Merge pull request #3874 from google/benvanik-hack-and-slash
* f4f4ea2 Use UnitTestSpec in tf.keras.layers tests (#3935)
* 7b8e9f7 Reverting flatcc to use our own cmake file for cross-compilation.
* 323e1fd Simplify dylib driver switch.
* 55f3de0 Only register VMLA driver in bindings/java/.
* f429916 Fix warning flag on Windows and HAL CTS driver registration. (#3911)
* 7951e22 Drop IREE_DRIVER_MODULES and iree/base:initializer from ModelBuilder.
* 4e111e2 Disable layering_check in iree/hal/drivers/BUILD.
* 4773736 Add package to iree/base/testing/BUILD.
* 7ca321c Skipping dylib driver in simple_embedding_test as a hack.
* 692deb5 Overriding the default MLIR -> LLVM module name.
* 513f40e Speculative removing nowindows tags (#3615). If there's something that still d..
* cc47813 Removing the broken forward declarations entirely from some codegen code. http..
* fbcad44 Removing _GNU_SOURCE copt for wait_handle.
* c9b10a0 Fixing bad type in hal/api.h (been there for ages!).
* e0c532e Changing iree::InitializeEnvironment to iree_flags_parse. Preparation for #3814.
* 8886ac0 Removing iree_api_init from the API.
* 132d747 Removing ALWAYSLINK support from cmake.
* 0ed81f6 Removing iree/base/initializer.h.
* 0135343 Changing to an explicit driver registration mechanism. This is required for ha..
* bf091d3 Removing ALWAYSLINK support from external_cc_library.
* d4bb871 Changing iree-tblgen to not require alwayslink.
* 6bc6f90 Removing IREE_COMMON_INCLUDE_DIRS and uses by LLVM/MLIR.
* 3c082aa Removing IREE_COMMON_INCLUDE_DIRS mhlo pollution.
* 2395cb9 Removing emitc usage of IREE_COMMON_INCLUDE_DIRS for now.
* 036bd96 TODOs on future library layout changes.
* c3a13e6 Rearranging iree/vm/ to reduce a public + cc target.
* 493b0e2 Rearranging iree/base build rules. By moving the dynamic_library_test out of t..
* 8fd38bf Replacing uses of some absl utilities now in C++14.
* 6786319 Removing unused absl/types/variant.h include.
* 99bd1af Replace absl::exchange with iree::exchange to reduce absl/utility dep.
* c1d0ee1 Removing unused PLATFORM_VULKAN_DEPS. It may be needed internally but it shoul..
* 15437f4 Simplifying iree/hal/dylib/ build config.
* e6984a5 Simplifying iree/hal/ build config.
* 1006281 Simplifying iree/hal/vulkan/ build config.
* 827e51b Simplifying iree/hal/llvmjit/ build config.
* 9a72f5d Simplifying iree/hal/metal/ build config.
* c7a7d72 Simplifying iree/hal/vmla/ build config.
* 90faf21 Adding IREE_TARGET_GUI_LINKOPTS to remove custom linkopts use.
* e5774c3 Remove unused args from flatbuffers_c_library macro.
* 22d16b4 Adding iree/base/flatcc.h to make flatcc easier to include.
* e44dee5 Switching from -DVK_NO_PROTOTYPES to iree/hal/vulkan/vulkan_headers.h.
* 48ca2fe Removing build-config setting of _GNU_SOURCE.
* eeb7dde Goodbye flatbuffers (well, the C++ ones anyway).
* 9c676a8 Removing all build config/utils related to flatbuffers.
* 49c6121 byte->ubyte in flatbuffer defs.
* c99000a Replacing compiler use of VM bytecode module def flatbuffers->flatcc.
* 1bf1e8d Replacing runtime use of metal executable flatbuffers->flatcc. Maybe it works?..
* 48aafb8 Replacing runtime use of spirv executable flatbuffers->flatcc.
* 011e9a2 Replacing runtime use of llvmjit executable flatbuffers->flatcc.
* a021062 Replacing runtime use of dylib executable flatbuffers->flatcc.
* 53a05d7 Replacing runtime use of VMLA executable flatbuffers->flatc.
* 99d30a9 Replacing compiler use of HAL executable flatbuffers->flatc.
* 6ebd1b0 Removing unused tag field in metal/spirv.
* bc685ed Adding flatcc json support and making iree-dump-module use it.
* 94b11c3 Adding include for flatcc to flat_c_libraries.
* 1172cf1 Removing unused iree::schemas::reflection_data.
* c86281a Removing unneeded flatbuffers copts.
* 7f3a7e3 Fixing various type warnings. We don't today have these warnings enabled in ou..
* c17659f Refining MSVC warning set to the minimum required and documenting.
* b7c92bf Cleaning up MSVC warnings and syncing with bazel warnings.
* 94356d3 Removing legacy repo_utils.bzl.
* 0f0d9c8 Prevent bazel-to-cmake from running on iree/base/CMakeLists.txt for now.
* 36225a4 Centralizing -ldl/-lpthread linkopts (as they were in bazel already).
* 31c4dbb Documenting iree_copts with a nice big warning.
* e4740a5 Pass android libraries as actual linkopts.
* 85cdd86 Fixing cmake style issues - prefer `if(` not `if (` please.
* bf4069e Sorting copts/linkopts so we can override things.
* 28040cd Simplifying VMA build integration.
* 479ef30 Replacing use of PROJECT_SOURCE_DIR/PROJECT_BINARY_DIR. Those use the previous..

COPYBARA_INTEGRATE_REVIEW=#4002 from rsuderman:main-to-google 4ef8891
PiperOrigin-RevId: 344157809
ScottTodd added a commit that referenced this pull request Dec 1, 2020
@ScottTodd
Merge main -> google
be489b8 
* f92602b Always emitting framepointers in generated ELFs (#3987)
* 89ef632 bump Tracy to get Android fixes (#3988)
* 7f989eb Disable MLIR crash reproducer on CI in python tests. (#3943)
* 4db3d08 Adding a demonstration of using the flow dialect post-partitioning. (#3701)
* 589dfa7 Remove no-longer-functional flag (#3961)
* 6454317 Fix MacOS builds after hack-and-slash PR (#3962)
* 8fb887e Update links to coverage tables (#3956)
* c93facb Adding iree_atomic_slist_t type. (#3917)
* bd082ca Merge pull request #3874 from google/benvanik-hack-and-slash
* f4f4ea2 Use UnitTestSpec in tf.keras.layers tests (#3935)
* 7b8e9f7 Reverting flatcc to use our own cmake file for cross-compilation.
* 323e1fd Simplify dylib driver switch.
* 55f3de0 Only register VMLA driver in bindings/java/.
* f429916 Fix warning flag on Windows and HAL CTS driver registration. (#3911)
* 7951e22 Drop IREE_DRIVER_MODULES and iree/base:initializer from ModelBuilder.
* 4e111e2 Disable layering_check in iree/hal/drivers/BUILD.
* 4773736 Add package to iree/base/testing/BUILD.
* 7ca321c Skipping dylib driver in simple_embedding_test as a hack.
* 692deb5 Overriding the default MLIR -> LLVM module name.
* 513f40e Speculative removing nowindows tags (#3615). If there's something that still d..
* cc47813 Removing the broken forward declarations entirely from some codegen code. http..
* fbcad44 Removing _GNU_SOURCE copt for wait_handle.
* c9b10a0 Fixing bad type in hal/api.h (been there for ages!).
* e0c532e Changing iree::InitializeEnvironment to iree_flags_parse. Preparation for #3814.
* 8886ac0 Removing iree_api_init from the API.
* 132d747 Removing ALWAYSLINK support from cmake.
* 0ed81f6 Removing iree/base/initializer.h.
* 0135343 Changing to an explicit driver registration mechanism. This is required for ha..
* bf091d3 Removing ALWAYSLINK support from external_cc_library.
* d4bb871 Changing iree-tblgen to not require alwayslink.
* 6bc6f90 Removing IREE_COMMON_INCLUDE_DIRS and uses by LLVM/MLIR.
* 3c082aa Removing IREE_COMMON_INCLUDE_DIRS mhlo pollution.
* 2395cb9 Removing emitc usage of IREE_COMMON_INCLUDE_DIRS for now.
* 036bd96 TODOs on future library layout changes.
* c3a13e6 Rearranging iree/vm/ to reduce a public + cc target.
* 493b0e2 Rearranging iree/base build rules. By moving the dynamic_library_test out of t..
* 8fd38bf Replacing uses of some absl utilities now in C++14.
* 6786319 Removing unused absl/types/variant.h include.
* 99bd1af Replace absl::exchange with iree::exchange to reduce absl/utility dep.
* c1d0ee1 Removing unused PLATFORM_VULKAN_DEPS. It may be needed internally but it shoul..
* 15437f4 Simplifying iree/hal/dylib/ build config.
* e6984a5 Simplifying iree/hal/ build config.
* 1006281 Simplifying iree/hal/vulkan/ build config.
* 827e51b Simplifying iree/hal/llvmjit/ build config.
* 9a72f5d Simplifying iree/hal/metal/ build config.
* c7a7d72 Simplifying iree/hal/vmla/ build config.
* 90faf21 Adding IREE_TARGET_GUI_LINKOPTS to remove custom linkopts use.
* e5774c3 Remove unused args from flatbuffers_c_library macro.
* 22d16b4 Adding iree/base/flatcc.h to make flatcc easier to include.
* e44dee5 Switching from -DVK_NO_PROTOTYPES to iree/hal/vulkan/vulkan_headers.h.
* 48ca2fe Removing build-config setting of _GNU_SOURCE.
* eeb7dde Goodbye flatbuffers (well, the C++ ones anyway).
* 9c676a8 Removing all build config/utils related to flatbuffers.
* 49c6121 byte->ubyte in flatbuffer defs.
* c99000a Replacing compiler use of VM bytecode module def flatbuffers->flatcc.
* 1bf1e8d Replacing runtime use of metal executable flatbuffers->flatcc. Maybe it works?..
* 48aafb8 Replacing runtime use of spirv executable flatbuffers->flatcc.
* 011e9a2 Replacing runtime use of llvmjit executable flatbuffers->flatcc.
* a021062 Replacing runtime use of dylib executable flatbuffers->flatcc.
* 53a05d7 Replacing runtime use of VMLA executable flatbuffers->flatc.
* 99d30a9 Replacing compiler use of HAL executable flatbuffers->flatc.
* 6ebd1b0 Removing unused tag field in metal/spirv.
* bc685ed Adding flatcc json support and making iree-dump-module use it.
* 94b11c3 Adding include for flatcc to flat_c_libraries.
* 1172cf1 Removing unused iree::schemas::reflection_data.
* c86281a Removing unneeded flatbuffers copts.
* 7f3a7e3 Fixing various type warnings. We don't today have these warnings enabled in ou..
* c17659f Refining MSVC warning set to the minimum required and documenting.
* b7c92bf Cleaning up MSVC warnings and syncing with bazel warnings.
* 94356d3 Removing legacy repo_utils.bzl.
* 0f0d9c8 Prevent bazel-to-cmake from running on iree/base/CMakeLists.txt for now.
* 36225a4 Centralizing -ldl/-lpthread linkopts (as they were in bazel already).
* 31c4dbb Documenting iree_copts with a nice big warning.
* e4740a5 Pass android libraries as actual linkopts.
* 85cdd86 Fixing cmake style issues - prefer `if(` not `if (` please.
* bf4069e Sorting copts/linkopts so we can override things.
* 28040cd Simplifying VMA build integration.
* 479ef30 Replacing use of PROJECT_SOURCE_DIR/PROJECT_BINARY_DIR. Those use the previous..

COPYBARA_INTEGRATE_REVIEW=#4002 from rsuderman:main-to-google 4ef8891
PiperOrigin-RevId: 344157809
ScottTodd added a commit that referenced this pull request Dec 1, 2020
@ScottTodd
Merge main -> google
69655bc 
* f92602b Always emitting framepointers in generated ELFs (#3987)
* 89ef632 bump Tracy to get Android fixes (#3988)
* 7f989eb Disable MLIR crash reproducer on CI in python tests. (#3943)
* 4db3d08 Adding a demonstration of using the flow dialect post-partitioning. (#3701)
* 589dfa7 Remove no-longer-functional flag (#3961)
* 6454317 Fix MacOS builds after hack-and-slash PR (#3962)
* 8fb887e Update links to coverage tables (#3956)
* c93facb Adding iree_atomic_slist_t type. (#3917)
* bd082ca Merge pull request #3874 from google/benvanik-hack-and-slash
* f4f4ea2 Use UnitTestSpec in tf.keras.layers tests (#3935)
* 7b8e9f7 Reverting flatcc to use our own cmake file for cross-compilation.
* 323e1fd Simplify dylib driver switch.
* 55f3de0 Only register VMLA driver in bindings/java/.
* f429916 Fix warning flag on Windows and HAL CTS driver registration. (#3911)
* 7951e22 Drop IREE_DRIVER_MODULES and iree/base:initializer from ModelBuilder.
* 4e111e2 Disable layering_check in iree/hal/drivers/BUILD.
* 4773736 Add package to iree/base/testing/BUILD.
* 7ca321c Skipping dylib driver in simple_embedding_test as a hack.
* 692deb5 Overriding the default MLIR -> LLVM module name.
* 513f40e Speculative removing nowindows tags (#3615). If there's something that still d..
* cc47813 Removing the broken forward declarations entirely from some codegen code. http..
* fbcad44 Removing _GNU_SOURCE copt for wait_handle.
* c9b10a0 Fixing bad type in hal/api.h (been there for ages!).
* e0c532e Changing iree::InitializeEnvironment to iree_flags_parse. Preparation for #3814.
* 8886ac0 Removing iree_api_init from the API.
* 132d747 Removing ALWAYSLINK support from cmake.
* 0ed81f6 Removing iree/base/initializer.h.
* 0135343 Changing to an explicit driver registration mechanism. This is required for ha..
* bf091d3 Removing ALWAYSLINK support from external_cc_library.
* d4bb871 Changing iree-tblgen to not require alwayslink.
* 6bc6f90 Removing IREE_COMMON_INCLUDE_DIRS and uses by LLVM/MLIR.
* 3c082aa Removing IREE_COMMON_INCLUDE_DIRS mhlo pollution.
* 2395cb9 Removing emitc usage of IREE_COMMON_INCLUDE_DIRS for now.
* 036bd96 TODOs on future library layout changes.
* c3a13e6 Rearranging iree/vm/ to reduce a public + cc target.
* 493b0e2 Rearranging iree/base build rules. By moving the dynamic_library_test out of t..
* 8fd38bf Replacing uses of some absl utilities now in C++14.
* 6786319 Removing unused absl/types/variant.h include.
* 99bd1af Replace absl::exchange with iree::exchange to reduce absl/utility dep.
* c1d0ee1 Removing unused PLATFORM_VULKAN_DEPS. It may be needed internally but it shoul..
* 15437f4 Simplifying iree/hal/dylib/ build config.
* e6984a5 Simplifying iree/hal/ build config.
* 1006281 Simplifying iree/hal/vulkan/ build config.
* 827e51b Simplifying iree/hal/llvmjit/ build config.
* 9a72f5d Simplifying iree/hal/metal/ build config.
* c7a7d72 Simplifying iree/hal/vmla/ build config.
* 90faf21 Adding IREE_TARGET_GUI_LINKOPTS to remove custom linkopts use.
* e5774c3 Remove unused args from flatbuffers_c_library macro.
* 22d16b4 Adding iree/base/flatcc.h to make flatcc easier to include.
* e44dee5 Switching from -DVK_NO_PROTOTYPES to iree/hal/vulkan/vulkan_headers.h.
* 48ca2fe Removing build-config setting of _GNU_SOURCE.
* eeb7dde Goodbye flatbuffers (well, the C++ ones anyway).
* 9c676a8 Removing all build config/utils related to flatbuffers.
* 49c6121 byte->ubyte in flatbuffer defs.
* c99000a Replacing compiler use of VM bytecode module def flatbuffers->flatcc.
* 1bf1e8d Replacing runtime use of metal executable flatbuffers->flatcc. Maybe it works?..
* 48aafb8 Replacing runtime use of spirv executable flatbuffers->flatcc.
* 011e9a2 Replacing runtime use of llvmjit executable flatbuffers->flatcc.
* a021062 Replacing runtime use of dylib executable flatbuffers->flatcc.
* 53a05d7 Replacing runtime use of VMLA executable flatbuffers->flatc.
* 99d30a9 Replacing compiler use of HAL executable flatbuffers->flatc.
* 6ebd1b0 Removing unused tag field in metal/spirv.
* bc685ed Adding flatcc json support and making iree-dump-module use it.
* 94b11c3 Adding include for flatcc to flat_c_libraries.
* 1172cf1 Removing unused iree::schemas::reflection_data.
* c86281a Removing unneeded flatbuffers copts.
* 7f3a7e3 Fixing various type warnings. We don't today have these warnings enabled in ou..
* c17659f Refining MSVC warning set to the minimum required and documenting.
* b7c92bf Cleaning up MSVC warnings and syncing with bazel warnings.
* 94356d3 Removing legacy repo_utils.bzl.
* 0f0d9c8 Prevent bazel-to-cmake from running on iree/base/CMakeLists.txt for now.
* 36225a4 Centralizing -ldl/-lpthread linkopts (as they were in bazel already).
* 31c4dbb Documenting iree_copts with a nice big warning.
* e4740a5 Pass android libraries as actual linkopts.
* 85cdd86 Fixing cmake style issues - prefer `if(` not `if (` please.
* bf4069e Sorting copts/linkopts so we can override things.
* 28040cd Simplifying VMA build integration.
* 479ef30 Replacing use of PROJECT_SOURCE_DIR/PROJECT_BINARY_DIR. Those use the previous..

PiperOrigin-RevId: 344157809
This was referenced Dec 2, 2020
Closed
Closed
copybara-service bot pushed a commit that referenced this pull request Dec 2, 2020
@ScottTodd @iree-copybara-bot
Merge main -> google
6e4260d 
* abf5456 Merge google -> main (#4045)
* 1e4349e Merge branch 'main' into google-to-main
* 1f86f0e Add new tf.keras.applications models (#3958)
* 41004a9 [spirv] Add a better tiled and vectorized convolution path (#3990)
* c412944 Bump Tracy to get Ben's dynamic zone colors and to get past (#4042)
* 2a25f5f Remove input shape hack from kws tests (#3959)
* 359ffa0 Allow fusing batch_matmul and fill (#4038)
* 35e837e Merge pull request #4008 from MaheshRavishankar/matmul_fusion
* ffdd9d1 Enable e2e execution of fusion of matmul with producer.
* de116a0 Use tile+fuse on CPU side.
* caf91ac Use fusion of sequence of LinalgOps in IREE SPIR-V codegen path.
* 551f254 Add convert f32 to f16 pass (#4010)
* f1b1e58 Use vector transfer forwarding and dead store elimination in IREE (#4032)
* fac8fd1 Add file to track docker :prod digests (#3955)
* 37f0ae8 Tensorlist refactor to remove shape input and support empty reserve behavior (..
* 7585e53 Add relative_artifacts_dir (#3960)
* da53889 Use subprocess.run and types in manage_images.py (#3947)
* fbc63a4 Upgrade PR action to v3 (#3946)
* 83ea4a3 [llvm] Add a PlanConvLoopOrder pass (#3920)
* 1f1c70a Merge pull request #4012
* bab1468 Submodule fix
* bab0308 Merge branch 'main' into google-to-main
* 8df7e5c Sort add_subdirectory and remove todo given it's fixed now (#4029)
* 1bb131c Add missing mkdir to fix building and publishing documentation (#4030)
* 46949ba Fix VectorizeMemref out-of-bound access (#4031)
* b32de09 Update Linux docs to include an LLVM AOT example (#3165)
* 40da454 Update docs to recommend enabling/disabling assertions globally. (#4014)
* fc8da03 Update Tracy to get clean shutdown on Android (#4015)
* 12e20ef support running as root on android. (#4013)
* 1a4f469 Merge branch 'main' into google-to-main
* aff3e9c Add vectorization support for batch_matmul op (#3997)
* 33d4a6b Changing iree/base/math.h to C and adding some PRNG routines. (#4005)
* 73bdbe7 Fixup EmitC include directories (#3983)
* af7b4c3 Refactor finding python3 to use standard cmake find_package (#3778)
* f92602b Always emitting framepointers in generated ELFs (#3987)
* 89ef632 bump Tracy to get Android fixes (#3988)
* 7f989eb Disable MLIR crash reproducer on CI in python tests. (#3943)
* 4db3d08 Adding a demonstration of using the flow dialect post-partitioning. (#3701)
* 589dfa7 Remove no-longer-functional flag (#3961)
* 6454317 Fix MacOS builds after hack-and-slash PR (#3962)
* 8fb887e Update links to coverage tables (#3956)
* c93facb Adding iree_atomic_slist_t type. (#3917)
* bd082ca Merge pull request #3874 from google/benvanik-hack-and-slash
* f4f4ea2 Use UnitTestSpec in tf.keras.layers tests (#3935)
* 7b8e9f7 Reverting flatcc to use our own cmake file for cross-compilation.
* 323e1fd Simplify dylib driver switch.
* 55f3de0 Only register VMLA driver in bindings/java/.
* f429916 Fix warning flag on Windows and HAL CTS driver registration. (#3911)
* 7951e22 Drop IREE_DRIVER_MODULES and iree/base:initializer from ModelBuilder.
* 4e111e2 Disable layering_check in iree/hal/drivers/BUILD.
* 4773736 Add package to iree/base/testing/BUILD.
* 7ca321c Skipping dylib driver in simple_embedding_test as a hack.
* 692deb5 Overriding the default MLIR -> LLVM module name.
* 513f40e Speculative removing nowindows tags (#3615). If there's something that still d..
* cc47813 Removing the broken forward declarations entirely from some codegen code. http..
* fbcad44 Removing _GNU_SOURCE copt for wait_handle.
* c9b10a0 Fixing bad type in hal/api.h (been there for ages!).
* e0c532e Changing iree::InitializeEnvironment to iree_flags_parse. Preparation for #3814.
* 8886ac0 Removing iree_api_init from the API.
* 132d747 Removing ALWAYSLINK support from cmake.
* 0ed81f6 Removing iree/base/initializer.h.
* 0135343 Changing to an explicit driver registration mechanism. This is required for ha..
* bf091d3 Removing ALWAYSLINK support from external_cc_library.
* d4bb871 Changing iree-tblgen to not require alwayslink.
* 6bc6f90 Removing IREE_COMMON_INCLUDE_DIRS and uses by LLVM/MLIR.
* 3c082aa Removing IREE_COMMON_INCLUDE_DIRS mhlo pollution.
* 2395cb9 Removing emitc usage of IREE_COMMON_INCLUDE_DIRS for now.
* 036bd96 TODOs on future library layout changes.
* c3a13e6 Rearranging iree/vm/ to reduce a public + cc target.
* 493b0e2 Rearranging iree/base build rules. By moving the dynamic_library_test out of t..
* 8fd38bf Replacing uses of some absl utilities now in C++14.
* 6786319 Removing unused absl/types/variant.h include.
* 99bd1af Replace absl::exchange with iree::exchange to reduce absl/utility dep.
* c1d0ee1 Removing unused PLATFORM_VULKAN_DEPS. It may be needed internally but it shoul..
* 15437f4 Simplifying iree/hal/dylib/ build config.
* e6984a5 Simplifying iree/hal/ build config.
* 1006281 Simplifying iree/hal/vulkan/ build config.
* 827e51b Simplifying iree/hal/llvmjit/ build config.
* 9a72f5d Simplifying iree/hal/metal/ build config.
* c7a7d72 Simplifying iree/hal/vmla/ build config.
* 90faf21 Adding IREE_TARGET_GUI_LINKOPTS to remove custom linkopts use.
* e5774c3 Remove unused args from flatbuffers_c_library macro.
* 22d16b4 Adding iree/base/flatcc.h to make flatcc easier to include.
* e44dee5 Switching from -DVK_NO_PROTOTYPES to iree/hal/vulkan/vulkan_headers.h.
* 48ca2fe Removing build-config setting of _GNU_SOURCE.
* eeb7dde Goodbye flatbuffers (well, the C++ ones anyway).
* 9c676a8 Removing all build config/utils related to flatbuffers.
* 49c6121 byte->ubyte in flatbuffer defs.
* c99000a Replacing compiler use of VM bytecode module def flatbuffers->flatcc.
* 1bf1e8d Replacing runtime use of metal executable flatbuffers->flatcc. Maybe it works?..
* 48aafb8 Replacing runtime use of spirv executable flatbuffers->flatcc.
* 011e9a2 Replacing runtime use of llvmjit executable flatbuffers->flatcc.
* a021062 Replacing runtime use of dylib executable flatbuffers->flatcc.
* 53a05d7 Replacing runtime use of VMLA executable flatbuffers->flatc.
* 99d30a9 Replacing compiler use of HAL executable flatbuffers->flatc.
* 6ebd1b0 Removing unused tag field in metal/spirv.
* bc685ed Adding flatcc json support and making iree-dump-module use it.
* 94b11c3 Adding include for flatcc to flat_c_libraries.
* 1172cf1 Removing unused iree::schemas::reflection_data.
* c86281a Removing unneeded flatbuffers copts.
* 7f3a7e3 Fixing various type warnings. We don't today have these warnings enabled in ou..
* c17659f Refining MSVC warning set to the minimum required and documenting.
* b7c92bf Cleaning up MSVC warnings and syncing with bazel warnings.
* 94356d3 Removing legacy repo_utils.bzl.
* 0f0d9c8 Prevent bazel-to-cmake from running on iree/base/CMakeLists.txt for now.
* 36225a4 Centralizing -ldl/-lpthread linkopts (as they were in bazel already).
* 31c4dbb Documenting iree_copts with a nice big warning.
* e4740a5 Pass android libraries as actual linkopts.
* 85cdd86 Fixing cmake style issues - prefer `if(` not `if (` please.
* bf4069e Sorting copts/linkopts so we can override things.
* 28040cd Simplifying VMA build integration.
* 479ef30 Replacing use of PROJECT_SOURCE_DIR/PROJECT_BINARY_DIR. Those use the previous..

COPYBARA_INTEGRATE_REVIEW=#4048 from ScottTodd:main-to-google abf5456
PiperOrigin-RevId: 345252359
ScottTodd added a commit that referenced this pull request Dec 2, 2020
@ScottTodd
Merge main -> google
1f4b61e 
* abf5456 Merge google -> main (#4045)
* 1e4349e Merge branch 'main' into google-to-main
* 1f86f0e Add new tf.keras.applications models (#3958)
* 41004a9 [spirv] Add a better tiled and vectorized convolution path (#3990)
* c412944 Bump Tracy to get Ben's dynamic zone colors and to get past (#4042)
* 2a25f5f Remove input shape hack from kws tests (#3959)
* 359ffa0 Allow fusing batch_matmul and fill (#4038)
* 35e837e Merge pull request #4008 from MaheshRavishankar/matmul_fusion
* ffdd9d1 Enable e2e execution of fusion of matmul with producer.
* de116a0 Use tile+fuse on CPU side.
* caf91ac Use fusion of sequence of LinalgOps in IREE SPIR-V codegen path.
* 551f254 Add convert f32 to f16 pass (#4010)
* f1b1e58 Use vector transfer forwarding and dead store elimination in IREE (#4032)
* fac8fd1 Add file to track docker :prod digests (#3955)
* 37f0ae8 Tensorlist refactor to remove shape input and support empty reserve behavior (..
* 7585e53 Add relative_artifacts_dir (#3960)
* da53889 Use subprocess.run and types in manage_images.py (#3947)
* fbc63a4 Upgrade PR action to v3 (#3946)
* 83ea4a3 [llvm] Add a PlanConvLoopOrder pass (#3920)
* 1f1c70a Merge pull request #4012
* bab1468 Submodule fix
* bab0308 Merge branch 'main' into google-to-main
* 8df7e5c Sort add_subdirectory and remove todo given it's fixed now (#4029)
* 1bb131c Add missing mkdir to fix building and publishing documentation (#4030)
* 46949ba Fix VectorizeMemref out-of-bound access (#4031)
* b32de09 Update Linux docs to include an LLVM AOT example (#3165)
* 40da454 Update docs to recommend enabling/disabling assertions globally. (#4014)
* fc8da03 Update Tracy to get clean shutdown on Android (#4015)
* 12e20ef support running as root on android. (#4013)
* 1a4f469 Merge branch 'main' into google-to-main
* aff3e9c Add vectorization support for batch_matmul op (#3997)
* 33d4a6b Changing iree/base/math.h to C and adding some PRNG routines. (#4005)
* 73bdbe7 Fixup EmitC include directories (#3983)
* af7b4c3 Refactor finding python3 to use standard cmake find_package (#3778)
* f92602b Always emitting framepointers in generated ELFs (#3987)
* 89ef632 bump Tracy to get Android fixes (#3988)
* 7f989eb Disable MLIR crash reproducer on CI in python tests. (#3943)
* 4db3d08 Adding a demonstration of using the flow dialect post-partitioning. (#3701)
* 589dfa7 Remove no-longer-functional flag (#3961)
* 6454317 Fix MacOS builds after hack-and-slash PR (#3962)
* 8fb887e Update links to coverage tables (#3956)
* c93facb Adding iree_atomic_slist_t type. (#3917)
* bd082ca Merge pull request #3874 from google/benvanik-hack-and-slash
* f4f4ea2 Use UnitTestSpec in tf.keras.layers tests (#3935)
* 7b8e9f7 Reverting flatcc to use our own cmake file for cross-compilation.
* 323e1fd Simplify dylib driver switch.
* 55f3de0 Only register VMLA driver in bindings/java/.
* f429916 Fix warning flag on Windows and HAL CTS driver registration. (#3911)
* 7951e22 Drop IREE_DRIVER_MODULES and iree/base:initializer from ModelBuilder.
* 4e111e2 Disable layering_check in iree/hal/drivers/BUILD.
* 4773736 Add package to iree/base/testing/BUILD.
* 7ca321c Skipping dylib driver in simple_embedding_test as a hack.
* 692deb5 Overriding the default MLIR -> LLVM module name.
* 513f40e Speculative removing nowindows tags (#3615). If there's something that still d..
* cc47813 Removing the broken forward declarations entirely from some codegen code. http..
* fbcad44 Removing _GNU_SOURCE copt for wait_handle.
* c9b10a0 Fixing bad type in hal/api.h (been there for ages!).
* e0c532e Changing iree::InitializeEnvironment to iree_flags_parse. Preparation for #3814.
* 8886ac0 Removing iree_api_init from the API.
* 132d747 Removing ALWAYSLINK support from cmake.
* 0ed81f6 Removing iree/base/initializer.h.
* 0135343 Changing to an explicit driver registration mechanism. This is required for ha..
* bf091d3 Removing ALWAYSLINK support from external_cc_library.
* d4bb871 Changing iree-tblgen to not require alwayslink.
* 6bc6f90 Removing IREE_COMMON_INCLUDE_DIRS and uses by LLVM/MLIR.
* 3c082aa Removing IREE_COMMON_INCLUDE_DIRS mhlo pollution.
* 2395cb9 Removing emitc usage of IREE_COMMON_INCLUDE_DIRS for now.
* 036bd96 TODOs on future library layout changes.
* c3a13e6 Rearranging iree/vm/ to reduce a public + cc target.
* 493b0e2 Rearranging iree/base build rules. By moving the dynamic_library_test out of t..
* 8fd38bf Replacing uses of some absl utilities now in C++14.
* 6786319 Removing unused absl/types/variant.h include.
* 99bd1af Replace absl::exchange with iree::exchange to reduce absl/utility dep.
* c1d0ee1 Removing unused PLATFORM_VULKAN_DEPS. It may be needed internally but it shoul..
* 15437f4 Simplifying iree/hal/dylib/ build config.
* e6984a5 Simplifying iree/hal/ build config.
* 1006281 Simplifying iree/hal/vulkan/ build config.
* 827e51b Simplifying iree/hal/llvmjit/ build config.
* 9a72f5d Simplifying iree/hal/metal/ build config.
* c7a7d72 Simplifying iree/hal/vmla/ build config.
* 90faf21 Adding IREE_TARGET_GUI_LINKOPTS to remove custom linkopts use.
* e5774c3 Remove unused args from flatbuffers_c_library macro.
* 22d16b4 Adding iree/base/flatcc.h to make flatcc easier to include.
* e44dee5 Switching from -DVK_NO_PROTOTYPES to iree/hal/vulkan/vulkan_headers.h.
* 48ca2fe Removing build-config setting of _GNU_SOURCE.
* eeb7dde Goodbye flatbuffers (well, the C++ ones anyway).
* 9c676a8 Removing all build config/utils related to flatbuffers.
* 49c6121 byte->ubyte in flatbuffer defs.
* c99000a Replacing compiler use of VM bytecode module def flatbuffers->flatcc.
* 1bf1e8d Replacing runtime use of metal executable flatbuffers->flatcc. Maybe it works?..
* 48aafb8 Replacing runtime use of spirv executable flatbuffers->flatcc.
* 011e9a2 Replacing runtime use of llvmjit executable flatbuffers->flatcc.
* a021062 Replacing runtime use of dylib executable flatbuffers->flatcc.
* 53a05d7 Replacing runtime use of VMLA executable flatbuffers->flatc.
* 99d30a9 Replacing compiler use of HAL executable flatbuffers->flatc.
* 6ebd1b0 Removing unused tag field in metal/spirv.
* bc685ed Adding flatcc json support and making iree-dump-module use it.
* 94b11c3 Adding include for flatcc to flat_c_libraries.
* 1172cf1 Removing unused iree::schemas::reflection_data.
* c86281a Removing unneeded flatbuffers copts.
* 7f3a7e3 Fixing various type warnings. We don't today have these warnings enabled in ou..
* c17659f Refining MSVC warning set to the minimum required and documenting.
* b7c92bf Cleaning up MSVC warnings and syncing with bazel warnings.
* 94356d3 Removing legacy repo_utils.bzl.
* 0f0d9c8 Prevent bazel-to-cmake from running on iree/base/CMakeLists.txt for now.
* 36225a4 Centralizing -ldl/-lpthread linkopts (as they were in bazel already).
* 31c4dbb Documenting iree_copts with a nice big warning.
* e4740a5 Pass android libraries as actual linkopts.
* 85cdd86 Fixing cmake style issues - prefer `if(` not `if (` please.
* bf4069e Sorting copts/linkopts so we can override things.
* 28040cd Simplifying VMA build integration.
* 479ef30 Replacing use of PROJECT_SOURCE_DIR/PROJECT_BINARY_DIR. Those use the previous..

COPYBARA_INTEGRATE_REVIEW=#4048 from ScottTodd:main-to-google abf5456
PiperOrigin-RevId: 345252359
This was referenced Dec 2, 2020
Closed
Closed
GMNGeoffrey added a commit that referenced this pull request Dec 2, 2020
@GMNGeoffrey
Merge main -> google (#4048)
69f19b3 
* abf5456 Merge google -> main (#4045)
* 1e4349e Merge branch 'main' into google-to-main
* 1f86f0e Add new tf.keras.applications models (#3958)
* 41004a9 [spirv] Add a better tiled and vectorized convolution path (#3990)
* c412944 Bump Tracy to get Ben's dynamic zone colors and to get past (#4042)
* 2a25f5f Remove input shape hack from kws tests (#3959)
* 359ffa0 Allow fusing batch_matmul and fill (#4038)
* 35e837e Merge pull request #4008 from MaheshRavishankar/matmul_fusion
* ffdd9d1 Enable e2e execution of fusion of matmul with producer.
* de116a0 Use tile+fuse on CPU side.
* caf91ac Use fusion of sequence of LinalgOps in IREE SPIR-V codegen path.
* 551f254 Add convert f32 to f16 pass (#4010)
* f1b1e58 Use vector transfer forwarding and dead store elimination in IREE (#4032)
* fac8fd1 Add file to track docker :prod digests (#3955)
* 37f0ae8 Tensorlist refactor to remove shape input and support empty reserve behavior (..
* 7585e53 Add relative_artifacts_dir (#3960)
* da53889 Use subprocess.run and types in manage_images.py (#3947)
* fbc63a4 Upgrade PR action to v3 (#3946)
* 83ea4a3 [llvm] Add a PlanConvLoopOrder pass (#3920)
* 1f1c70a Merge pull request #4012
* bab1468 Submodule fix
* bab0308 Merge branch 'main' into google-to-main
* 8df7e5c Sort add_subdirectory and remove todo given it's fixed now (#4029)
* 1bb131c Add missing mkdir to fix building and publishing documentation (#4030)
* 46949ba Fix VectorizeMemref out-of-bound access (#4031)
* b32de09 Update Linux docs to include an LLVM AOT example (#3165)
* 40da454 Update docs to recommend enabling/disabling assertions globally. (#4014)
* fc8da03 Update Tracy to get clean shutdown on Android (#4015)
* 12e20ef support running as root on android. (#4013)
* 1a4f469 Merge branch 'main' into google-to-main
* aff3e9c Add vectorization support for batch_matmul op (#3997)
* 33d4a6b Changing iree/base/math.h to C and adding some PRNG routines. (#4005)
* 73bdbe7 Fixup EmitC include directories (#3983)
* af7b4c3 Refactor finding python3 to use standard cmake find_package (#3778)
* f92602b Always emitting framepointers in generated ELFs (#3987)
* 89ef632 bump Tracy to get Android fixes (#3988)
* 7f989eb Disable MLIR crash reproducer on CI in python tests. (#3943)
* 4db3d08 Adding a demonstration of using the flow dialect post-partitioning. (#3701)
* 589dfa7 Remove no-longer-functional flag (#3961)
* 6454317 Fix MacOS builds after hack-and-slash PR (#3962)
* 8fb887e Update links to coverage tables (#3956)
* c93facb Adding iree_atomic_slist_t type. (#3917)
* bd082ca Merge pull request #3874 from google/benvanik-hack-and-slash
* f4f4ea2 Use UnitTestSpec in tf.keras.layers tests (#3935)
* 7b8e9f7 Reverting flatcc to use our own cmake file for cross-compilation.
* 323e1fd Simplify dylib driver switch.
* 55f3de0 Only register VMLA driver in bindings/java/.
* f429916 Fix warning flag on Windows and HAL CTS driver registration. (#3911)
* 7951e22 Drop IREE_DRIVER_MODULES and iree/base:initializer from ModelBuilder.
* 4e111e2 Disable layering_check in iree/hal/drivers/BUILD.
* 4773736 Add package to iree/base/testing/BUILD.
* 7ca321c Skipping dylib driver in simple_embedding_test as a hack.
* 692deb5 Overriding the default MLIR -> LLVM module name.
* 513f40e Speculative removing nowindows tags (#3615). If there's something that still d..
* cc47813 Removing the broken forward declarations entirely from some codegen code. http..
* fbcad44 Removing _GNU_SOURCE copt for wait_handle.
* c9b10a0 Fixing bad type in hal/api.h (been there for ages!).
* e0c532e Changing iree::InitializeEnvironment to iree_flags_parse. Preparation for #3814.
* 8886ac0 Removing iree_api_init from the API.
* 132d747 Removing ALWAYSLINK support from cmake.
* 0ed81f6 Removing iree/base/initializer.h.
* 0135343 Changing to an explicit driver registration mechanism. This is required for ha..
* bf091d3 Removing ALWAYSLINK support from external_cc_library.
* d4bb871 Changing iree-tblgen to not require alwayslink.
* 6bc6f90 Removing IREE_COMMON_INCLUDE_DIRS and uses by LLVM/MLIR.
* 3c082aa Removing IREE_COMMON_INCLUDE_DIRS mhlo pollution.
* 2395cb9 Removing emitc usage of IREE_COMMON_INCLUDE_DIRS for now.
* 036bd96 TODOs on future library layout changes.
* c3a13e6 Rearranging iree/vm/ to reduce a public + cc target.
* 493b0e2 Rearranging iree/base build rules. By moving the dynamic_library_test out of t..
* 8fd38bf Replacing uses of some absl utilities now in C++14.
* 6786319 Removing unused absl/types/variant.h include.
* 99bd1af Replace absl::exchange with iree::exchange to reduce absl/utility dep.
* c1d0ee1 Removing unused PLATFORM_VULKAN_DEPS. It may be needed internally but it shoul..
* 15437f4 Simplifying iree/hal/dylib/ build config.
* e6984a5 Simplifying iree/hal/ build config.
* 1006281 Simplifying iree/hal/vulkan/ build config.
* 827e51b Simplifying iree/hal/llvmjit/ build config.
* 9a72f5d Simplifying iree/hal/metal/ build config.
* c7a7d72 Simplifying iree/hal/vmla/ build config.
* 90faf21 Adding IREE_TARGET_GUI_LINKOPTS to remove custom linkopts use.
* e5774c3 Remove unused args from flatbuffers_c_library macro.
* 22d16b4 Adding iree/base/flatcc.h to make flatcc easier to include.
* e44dee5 Switching from -DVK_NO_PROTOTYPES to iree/hal/vulkan/vulkan_headers.h.
* 48ca2fe Removing build-config setting of _GNU_SOURCE.
* eeb7dde Goodbye flatbuffers (well, the C++ ones anyway).
* 9c676a8 Removing all build config/utils related to flatbuffers.
* 49c6121 byte->ubyte in flatbuffer defs.
* c99000a Replacing compiler use of VM bytecode module def flatbuffers->flatcc.
* 1bf1e8d Replacing runtime use of metal executable flatbuffers->flatcc. Maybe it works?..
* 48aafb8 Replacing runtime use of spirv executable flatbuffers->flatcc.
* 011e9a2 Replacing runtime use of llvmjit executable flatbuffers->flatcc.
* a021062 Replacing runtime use of dylib executable flatbuffers->flatcc.
* 53a05d7 Replacing runtime use of VMLA executable flatbuffers->flatc.
* 99d30a9 Replacing compiler use of HAL executable flatbuffers->flatc.
* 6ebd1b0 Removing unused tag field in metal/spirv.
* bc685ed Adding flatcc json support and making iree-dump-module use it.
* 94b11c3 Adding include for flatcc to flat_c_libraries.
* 1172cf1 Removing unused iree::schemas::reflection_data.
* c86281a Removing unneeded flatbuffers copts.
* 7f3a7e3 Fixing various type warnings. We don't today have these warnings enabled in ou..
* c17659f Refining MSVC warning set to the minimum required and documenting.
* b7c92bf Cleaning up MSVC warnings and syncing with bazel warnings.
* 94356d3 Removing legacy repo_utils.bzl.
* 0f0d9c8 Prevent bazel-to-cmake from running on iree/base/CMakeLists.txt for now.
* 36225a4 Centralizing -ldl/-lpthread linkopts (as they were in bazel already).
* 31c4dbb Documenting iree_copts with a nice big warning.
* e4740a5 Pass android libraries as actual linkopts.
* 85cdd86 Fixing cmake style issues - prefer `if(` not `if (` please.
* bf4069e Sorting copts/linkopts so we can override things.
* 28040cd Simplifying VMA build integration.
* 479ef30 Replacing use of PROJECT_SOURCE_DIR/PROJECT_BINARY_DIR. Those use the previous..

PiperOrigin-RevId: 345252359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benvanik benvanik benvanik approved these changes

@phoenix-meadowlark phoenix-meadowlark phoenix-meadowlark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ScottTodd @phoenix-meadowlark @benvanik