Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally apply Conv -> Img2col transformation at the flow level #5596

Merged
merged 1 commit into from Apr 26, 2021
Merged

Optionally apply Conv -> Img2col transformation at the flow level #5596

merged 1 commit into from Apr 26, 2021

Conversation

asaadaldien
Copy link
Contributor

  • An alternative is to apply img2col after dispatching into workgroup tiles, but its running through multiple hops of issues related to introduced reshapes semantics.

Benchmarking resent50 (a model with lots of conv) on Pixel4:

----------------------------------------------------------------------------
Benchmark                                  Time             CPU   Iterations
----------------------------------------------------------------------------
BM_predict/process_time/real_time       8384 ms         8361 ms            1

----------------------------------------------------------------------------
Benchmark                                  Time             CPU   Iterations
----------------------------------------------------------------------------
BM_predict/process_time/real_time       3800 ms         3790 ms            1

@asaadaldien
Optionally apply Conv -> Img2col transformation at the flow level
0155113 
- An alternative is to apply this after dispatching into workgroup tiles
but its running throw multiple hops of issues related to
reshapes semantics subtensor inserts.
@google-cla google-cla bot added the cla: yes label Apr 23, 2021
@asaadaldien asaadaldien merged commit 9a0ea6e into main Apr 26, 2021
@asaadaldien asaadaldien deleted the ataei-optionally_do_img2col branch April 26, 2021 18:58
@ThomasRaoux ThomasRaoux mentioned this pull request Apr 26, 2021
Merged
simon-camp pushed a commit to simon-camp/iree that referenced this pull request Apr 29, 2021
@asaadaldien @simon-camp
Optionally apply Conv -> Img2col transformation at the flow level (ir…
0f4f09e 
…ee-org#5596)

- An alternative is to apply this after dispatching into workgroup tiles but its running throw multiple hops of issues related to
reshapes semantics subtensor inserts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaheshRavishankar MaheshRavishankar MaheshRavishankar approved these changes

@hanhanW hanhanW hanhanW approved these changes

@antiagainst antiagainst Awaiting requested review from antiagainst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asaadaldien @MaheshRavishankar @hanhanW