Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create or update comments for benchmark results #6145

Merged
merged 4 commits into from
Jun 9, 2021

Conversation

antiagainst
Copy link
Contributor

This is a follow up to #6124,
where we categorized and sorted benchmark result tables.
But it's still noisy given we are posting many abbreviated
summary tables. This tries to reduce that by trying to find
the last previous comment from the bot's account and
update that.

Also, using issue API endpoints instead of pull request ones,
in the hope to avoid putting the bot as a "reviewer".

Only the last commit matters.

@google-cla google-cla bot added the cla: yes label Jun 8, 2021
@antiagainst antiagainst added the (deprecated) buildkite:benchmark-android Deprecated. Please use benchmarks:android-* label Jun 8, 2021
@antiagainst antiagainst changed the title Create or update Create or update comments for benchmark results Jun 8, 2021
@iree-github-actions-bot
Copy link
Contributor

iree-github-actions-bot commented Jun 8, 2021

Abbreviated Benchmark Summary

@ commit d66e7e070b3da7bf2ee3ada4cd12161ef53e9622 (vs. base af7dfeb5394d92b2df1d5e6014d52fed9d5a07ff)

Similar Benchmarks

Benchmark Name Average Latency (ms) Median Latency (ms) Latency Standard Deviation (ms)
MobileNetV2 [fp32,imagenet] (TensorFlow) kernel-execution with IREE-Vulkan @ SM-G980F (GPU-Mali-G77) 22 22 1
MobileNetV2 [fp32,imagenet] (TensorFlow) 3-thread,little-core,full-inference with IREE-Dylib @ SM-G980F (CPU-ARMv8.2-A) 872 872 6
MobileNetV2 [fp32,imagenet] (TensorFlow) 1-thread,little-core,full-inference with IREE-Dylib @ SM-G980F (CPU-ARMv8.2-A) 1255 1256 6

[Top 3 out of 36 benchmark results showed]

For more information:

@antiagainst antiagainst marked this pull request as ready for review June 8, 2021 21:20
@antiagainst
Copy link
Contributor Author

Thanks Scott for the suggestion. Looks using API endpoints for issues does work here. There is only one comment now and it was edited for the second build. :)

Copy link
Collaborator

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, and thanks for pointing out the edit history @benvanik !

image

@antiagainst antiagainst merged commit 0417126 into iree-org:main Jun 9, 2021
@antiagainst antiagainst deleted the create-or-update branch June 9, 2021 00:09
@NatashaKnk NatashaKnk mentioned this pull request Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(deprecated) buildkite:benchmark-android Deprecated. Please use benchmarks:android-*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants