-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there a plan to support chunking? #59
Comments
"Bundling" is not done by J2Cl, but by the Closure Compiler (or anything else that's compatible with Closure's way of loading modules). |
@tbroyer, yes, indeed. however, Closure Compiler won't "chunk" (bundling is another term) without proper invocation. i know there is a CLI-based set of flags for defining chunk boundaries, and optimization passes specific to chunking. however, i do not think J2CL is equipped to invoke Closure this way. |
Until this is high level support at underlying rules level (closure), we are not planning to do our own solution. |
@gkdn okay but do you care if users want it? i'm the author of a proposal to bring this to Rules Closure. it would be useful to keep this issue open to track how it might be adopted in J2CL https://docs.google.com/document/d/1LxcJhpv5YEWAO28SiFYdKavIkSno4I4rY8UX3w_krKg we can't really adopt J2CL without some form of chunking (it's not bundling because we're splitting code here, this is the terminology the compiler uses). |
I closed the issue because it was a question. Internally, our users didn't need anything beyond the chunking provided by the underlying closure rules. However internally, we didn't provide a j2cl_application rule as well (since most users didn't need such a bootstrap). |
@gkdn understood |
If this question is related to build, please include version of Bazel that you are running J2CL with:
I'm wondering if J2CL plans to support JS chunking? We are very happy with J2CL so far. But, if we want to build a large application and serve it efficiently, we're worried about packaging everything up in one JS target.
Surely Gmail, Calendar, and the other examples cited, must have some wiring for chunking built in. Just curious if there is a plan or ideas to do this with J2CL.
The text was updated successfully, but these errors were encountered: