Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

J2ObjC Protoc 3.5.1 failing in some environments #970

Closed
Daeda88 opened this issue Apr 23, 2018 · 3 comments
Closed

J2ObjC Protoc 3.5.1 failing in some environments #970

Daeda88 opened this issue Apr 23, 2018 · 3 comments
Assignees

Comments

@Daeda88
Copy link

Daeda88 commented Apr 23, 2018

It seems the latest release of J2Objc has problems running j2objc_protoc in some environments, most notably Travis. This problem has happened on other versions of the library before and was usually fixed by the team quite fast.

See also https://groups.google.com/forum/#!topic/j2objc-discuss/qLvM4qP6A_8

@tomball tomball self-assigned this Apr 23, 2018
@tomball
Copy link
Collaborator

tomball commented Apr 23, 2018

Our internal release doc had the old protobuf version number. I'll update it and rebuild a 2.1.1.

FWIW, I'm surprised that a protobuf user needs a release build. Protocol buffers are a fairly advanced subject, and all that's needed to create a release build is download the source and run "make dist". The release builds are mostly for developers new to iOS development, especially those unfamiliar with shells and command-line tools. There's nothing special about a released build, as anyone can checkout that tag and rebuild it to get the same bits.

@Daeda88
Copy link
Author

Daeda88 commented Apr 23, 2018

Thank you for the quick response! While I have no doubt we could rebuild the library manually ourselves, due to it's size we tend to keep it out of our own Git repositories and just download it from Github through a script whenever we need to. Hence our current reliance on the release flags.

@tomball
Copy link
Collaborator

tomball commented Apr 23, 2018

Fixed in release 2.1.1.

@tomball tomball closed this as completed Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants