Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve pjit pytree error involving Nones (and PytreeLeafs) #13074

Open
2 tasks
mattjj opened this issue Nov 2, 2022 · 1 comment
Open
2 tasks

improve pjit pytree error involving Nones (and PytreeLeafs) #13074

mattjj opened this issue Nov 2, 2022 · 1 comment
Assignees
@mattjj
Labels
better_errors Improve the error reporting good first issue Good for newcomers

Comments

@mattjj
Copy link
Member

mattjj commented Nov 2, 2022 •
edited

When pjit's in_axis_resoures is not a pytree prefix of the corresponding arguments' pytrees, we attempt to raise a good error. But at least two things can be improved:

  • don't mention PytreeLeaf instances in the error message
  • handle None specially (since it's surprising for the error message to refer to it as a container)
@mattjj mattjj added bug Something isn't working better_errors Improve the error reporting and removed bug Something isn't working labels Nov 2, 2022
@mattjj mattjj self-assigned this Nov 2, 2022
@mattjj mattjj added the good first issue Good for newcomers label Feb 5, 2023
@teimilola
Copy link

teimilola commented May 22, 2023 •
edited

Looked into this briefly. It looks like 'in_axis_resources' is being deprecated in favor of in_shardings. Is this still an issue? Trying to pick up a good first issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattjj mattjj

Labels
better_errors Improve the error reporting good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattjj @teimilola