Rename opaque dtype to extended dtype. #16824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjj
approved these changes
Jul 24, 2023
froystig
approved these changes
Jul 24, 2023
This includes three deprecations: - jax.core.is_opaque_dtype(dt) is deprecated in favor of jnp.issubdtype(dt, jax.dtypes.extended) - jax.core.has_opaque_dtype(x) is deprecated in favor of jnp.issubdtype(x.dtype, jax.dtypes.extended) - the allow_opaque_dtype argument to jax.core.canonicalize_dtype is now allow_extended_dtype Because jax.core is explicitly excluded from the API deprecation policy, these changes will not be subject to a standard 3-month deprecation period.
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
-- b243ea7 by Jake VanderPlas <jakevdp@google.com>: Rename opaque dtype to extended dtype. This includes three deprecations: - jax.core.is_opaque_dtype(dt) is deprecated in favor of jnp.issubdtype(dt, jax.dtypes.extended) - jax.core.has_opaque_dtype(x) is deprecated in favor of jnp.issubdtype(x.dtype, jax.dtypes.extended) - the allow_opaque_dtype argument to jax.core.canonicalize_dtype is now allow_extended_dtype Because jax.core is explicitly excluded from the API deprecation policy, these changes will not be subject to a standard 3-month deprecation period. COPYBARA_INTEGRATE_REVIEW=#16824 from jakevdp:extended-dtype b243ea7 PiperOrigin-RevId: 550674205
|
Merged in b4132b4 |
copybara-service bot
pushed a commit
to google-research/kauldron
that referenced
this pull request
Jul 24, 2023
PiperOrigin-RevId: 550690856
copybara-service bot
pushed a commit
to jax-ml/oryx
that referenced
this pull request
Jul 24, 2023
PiperOrigin-RevId: 550690857
copybara-service bot
pushed a commit
to jax-ml/oryx
that referenced
this pull request
Jul 24, 2023
PiperOrigin-RevId: 550690857
copybara-service bot
pushed a commit
to jax-ml/oryx
that referenced
this pull request
Jul 24, 2023
PiperOrigin-RevId: 550712132
copybara-service bot
pushed a commit
to google-research/kauldron
that referenced
this pull request
Jul 25, 2023
PiperOrigin-RevId: 550690856
copybara-service bot
pushed a commit
to google-research/kauldron
that referenced
this pull request
Jul 25, 2023
PiperOrigin-RevId: 550945288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes three deprecations:
jax.core.is_opaque_dtype(dt)is deprecated in favor ofjnp.issubdtype(dt, jax.dtypes.extended).jax.core.has_opaque_dtype(x)is deprecated in favor ofjnp.issubdtype(x.dtype, jax.dtypes.extended).allow_opaque_dtypeargument tojax.core.canonicalize_dtypeis nowallow_extended_dtype.All of these APIs are in
jax.core, which is explicitly excluded from the API Deprecation Policy, so these will not be mentioned in the changelog, nor will they be subject to the standard 3-month deprecation period.