jnp.take: require array argument (but not indices) to be arraylike #7907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about add a warning for |
jakevdp
force-pushed
the
take-arraylike
branch
from
b3f2e0d
to
602e0dd
Compare
mattjj
approved these changes
Sep 14, 2021
google-ml-butler
bot
added
kokoro:force-run
pull ready
jakevdp
force-pushed
the
take-arraylike
branch
from
602e0dd
to
066a3bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7737
I'm leaving out the
indicesargument for now, because it's quite common downstream for users to pass lists of indices tojnp.take. I will likely revisit the indices later.