Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BacktrackingLineSearch created in LBFGS does not use same values for jit and unroll #174

Closed
ianwilliamson opened this issue Feb 19, 2022 · 1 comment
Closed

BacktrackingLineSearch created in LBFGS does not use same values for jit and unroll #174

ianwilliamson opened this issue Feb 19, 2022 · 1 comment

Comments

@ianwilliamson
Copy link
Contributor

I would have expected the line search in LBFGS to use the same values for its jit and unroll as the enclosing LBFGS optimizer, however this doesn't seem to be the case:

jaxopt/jaxopt/_src/lbfgs.py

Lines 258 to 262 in 0ff6be8

ls = BacktrackingLineSearch(fun=self._value_and_grad_fun,
value_and_grad=True,
maxiter=self.maxls,
decrease_factor=self.decrease_factor,
condition=self.condition)

Is this intentional?
This was referenced Feb 19, 2022
Closed
Merged
@mblondel
Copy link
Collaborator

Fixed by #175.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update line search in LBFGS to use jit and unroll settings from LBFGS ianwilliamson/jaxopt
2 participants
@mblondel @ianwilliamson