std.manifestYamlDoc(object, quote_keys=false) is slow

[alexander-svendsen]

When passing quote_keys=false to the method std.manifestYamlDoc it becomes really slow. Seems like the method checks if the key is safe to use without escaping. Uses the bareSafe method. This takes a lot of time.

Maybe the documentation should be updated to warn the users about it? Or the performance could be improved somehow. Or maybe let the users use force invalid keys without checking to lessen the performance hit?

[sparkprime]

It'd be worth trying to move the following sets out of the function so they don't get generated each time:

      local letters = std.set(std.stringChars('ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_-/'));
      local digits = std.set(std.stringChars('0123456789'));
      local intChars = std.set(digits + std.stringChars('_-'));
      local binChars = std.set(intChars + std.stringChars('b'));
      local hexChars = std.set(digits + std.stringChars('abcdefx_-'));
      local floatChars = std.set(digits + std.stringChars('e._-'));
      local dateChars = std.set(digits + std.stringChars('-'));
      local safeChars = std.set(letters + floatChars);

And also onlyChars could be rewritten to iterate over strSet and charSet to avoid creating an intermediate set.

[sparkprime]

Do you have a lot of keys in your YAML? Do the keys have a lot of characters?

[alexander-svendsen]

Nope, the object is not particularly large, or complicated:

      objectName: stuff,
      objectType: stuff2,
      objectAlias: stuff3,
      objectVersion: stuff4

I'm running std.manifestYamlDoc on about 5 such objects. but i noticed it got a lot slower, when using the quote_keys=false