Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write .clang-format for C++ style #143

Closed
davidzchen opened this issue Mar 26, 2016 · 2 comments
Closed

Write .clang-format for C++ style #143

davidzchen opened this issue Mar 26, 2016 · 2 comments

Comments

@davidzchen
Copy link
Contributor

Related to #142, add a .clang-format that codifies the C++ style for Jsonnet.

@sparkprime
Copy link
Member

I'd be OK with minimally changing the style if .clang-format is not able to enforce the way it currently is, so we should do this first, and then document the resulting state.

Presumably, it'll be possible to do run the C++ reformatter over the whole code base and update it, if that is the case?

@davidzchen
Copy link
Contributor Author

Sounds good to me. We can script clang-format to automatically reformat all the C++ files in the codebase using the style defined in the .clang-format file.

Once we have this done, we an also use clang-tidy to run lint checks, similar to what we do internally. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants