Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make include guards unique #50

Closed
elfring opened this issue May 7, 2015 · 3 comments
Closed

Make include guards unique #50

elfring opened this issue May 7, 2015 · 3 comments

Comments

@elfring
Copy link

elfring commented May 7, 2015

I find that include guards like "AST_H" and "VM_H" are too short for the safe reuse of your header files (when they belong to an application programming interface).

@sparkprime
Copy link
Member

So those files are not part of the API -- the only thing you need to include is lbijsonnet.h which currently has no header guards on account of only containing declarations that can be re-declared without errors. If I need to add header guards I'll use LIBJSONNET_H.

@sparkprime
Copy link
Member

I'll just add JSONNET_ to all the others though, it's not like it'll cost us anything.

@elfring
Copy link
Author

elfring commented May 7, 2015

Thanks for your improvement of include guards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants