Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exceptions in main()? #52

Closed
elfring opened this issue May 7, 2015 · 2 comments
Closed

Catch exceptions in main()? #52

elfring opened this issue May 7, 2015 · 2 comments
Labels

Comments

@elfring
Copy link

elfring commented May 7, 2015

I expect that exception handling is usually supported by a C++ program. I wonder why your function "main" does not contain corresponding try and catch instructions so far.

How do you think about recommendations by Matthew Wilson in an article?

Would you like to adjust the implementation if you consider effects for uncaught/unhandled exceptions like they are described by Danny Kalev?

@sparkprime
Copy link
Member

That sounds reasonable. Given libjsonnet.so is a C wrapper around C++, it should also catch all the std exceptions and give a catchall exception handler for anything else that might happen.

@elfring
Copy link
Author

elfring commented May 8, 2015

Thanks for your source code improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants