Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Maven build specifies code as 1.5, but code is actually 1.6 #137

Closed
GoogleCodeExporter opened this issue Mar 7, 2015 · 2 comments
Closed

Comments

@GoogleCodeExporter
Copy link

Use of @Override when implementing a Java interface is a 1.6 feature.  It is an 
error in 1.5.  So, the pom.xml should specify code as 1.6; the target can still 
be 1.5.

Patch here:
https://github.com/justinsb/keyczar/compare/fix_java_version.diff

Original issue reported on code.google.com by jus...@fathomdb.com on 12 Aug 2013 at 5:36

@GoogleCodeExporter
Copy link
Author

Here's an immutable version, in case I break my branches:
https://github.com/justinsb/keyczar/commit/e077de8cd09b0dff3212cefd2c26ecdbbc391
102.diff

Original comment by jus...@fathomdb.com on 12 Aug 2013 at 6:57

@GoogleCodeExporter
Copy link
Author

Actually, scratch this one.  On the command-line, maven requires bumping the 
target to 1.6 (though Eclipse figures it out).  Probably reasonable to target 
1.6, but not my call.

Original comment by jus...@fathomdb.com on 12 Aug 2013 at 10:14

@sweis sweis closed this as completed Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants