Add ko login #277
Merged
Add ko login #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 36.84% 37.88% +1.04%
==========================================
Files 33 33
Lines 1463 1507 +44
==========================================
+ Hits 539 571 +32
- Misses 835 845 +10
- Partials 89 91 +2
Continue to review full report at Codecov.
|
This was previously `ko auth login`, which I've hidden, and perhaps we can alias to `ko login` in the future, but in theory folks could have been using `ko auth get`, and I don't want to break that for no reason.
jonjohnsonjr
force-pushed
the
ko-login
branch
from
edcabad
to
c6e0564
Compare
mattmoor
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
This was previously
ko auth login, which I've hidden, and perhaps wecan alias to
ko loginin the future, but in theory folks could havebeen using
ko auth get, and I don't want to break that for no reason.