Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incremental: changes in independent classes in classpath don't propagate #630

Closed
ting-yuan opened this issue Sep 16, 2021 · 0 comments
Closed
Assignees
Labels
api API changes may be involved bug Something isn't working P1 major features or blocking bugs
Milestone

Comments

@ting-yuan
Copy link
Collaborator

They are expected to NOT propagate through class dependencies. However, they should propagate through outputs. For example, class Lib, which is obtained by getClassDeclarationByName or getDeclarationsFromPackage, and class Src are used to generated output O.kt. When Lib changes, Src should participate in reprocessing, no matter Src depends (directly or indirectly) on Lib or not.

Currently, the API only allows dependencies of outputs to be source files. An intuitive solution is something like assoicate(decl: KSDeclaration) which requires cooperation with processors.

Although we may introduce some virtual placeholders like AnyChanges, how to know whether an output depends on a class in classpath remains to be investigated, because KSDeclaration.containingFile is null for classes from classpath.

@ting-yuan ting-yuan added bug Something isn't working P1 major features or blocking bugs api API changes may be involved labels Sep 16, 2021
@ting-yuan ting-yuan added this to the 1.0.1 milestone Sep 16, 2021
@ting-yuan ting-yuan self-assigned this Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API changes may be involved bug Something isn't working P1 major features or blocking bugs
Projects
None yet
Development

No branches or pull requests

1 participant