Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

res/layout/address_layout.xml appears to be unused #56

Closed
liutikas opened this issue Dec 10, 2014 · 2 comments
Closed

res/layout/address_layout.xml appears to be unused #56

liutikas opened this issue Dec 10, 2014 · 2 comments
Assignees
@andyst

Comments

@liutikas
Copy link

java/res/layout/address_layout.xml file seems to be unused. Can it be deleted?
@roubert roubert self-assigned this Dec 10, 2014
@roubert
Copy link
Member

roubert commented Dec 10, 2014

It seems so. I guess that the original purpose of this file was to allow a user of the library (here I imagine some demo app used to test it during development) to just reference it, but if any such use of the file still exists then the file itself is trivial and could just be copied to the resources of that code using the library instead. I can't see any reason not to delete it.

@roubert roubert closed this as completed Dec 10, 2014
@liutikas
Copy link
Author

Could you please delete this then? (I do not have a repo setup to push changes to libaddressinput)

You can also delete please_select string that is not used anywhere.

@roubert roubert assigned andyst and unassigned roubert Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyst andyst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andyst @roubert @liutikas