You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks like all the callers of sxg_write_map_cbor_header pass in a size_t. For defense-in-depth, it would be nice to add an if (value < 0) do_something_else(); before each one is cast to a uint64_t.
Low risk. This isn't a buffer overflow risk. Worst case is we serve an invalid SXG that the browser rejects due to CBOR parse error.
The text was updated successfully, but these errors were encountered:
Looks like all the callers of
sxg_write_map_cbor_header
pass in asize_t
. For defense-in-depth, it would be nice to add anif (value < 0) do_something_else();
before each one is cast to auint64_t
.Low risk. This isn't a buffer overflow risk. Worst case is we serve an invalid SXG that the browser rejects due to CBOR parse error.
The text was updated successfully, but these errors were encountered: