Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Phabricator to use a staging area. #66

Closed
ChristianKuehnel opened this issue Nov 26, 2019 · 1 comment
Closed

Configure Phabricator to use a staging area. #66

ChristianKuehnel opened this issue Nov 26, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@ChristianKuehnel
Copy link
Collaborator

ChristianKuehnel commented Nov 26, 2019

basic idea

To properly be able to test the patches people upload, set up a "staging area" in Phabricator for the github monorepo. This way contributors upload the exact code they have locally, so that the build can be reproduced by the pre-merge tests:
https://secure.phabricator.com/book/phabricator/article/harbormaster/

This is based on a bug reported in #64 .

Drawbacks

  • This might have impact on contributor's workflows.
  • We need to set up and maintain the stating repository.
  • This still does not guarantee, that you patch can be cleanly applied to the master branch at the time of merging.
  • People still can merge somthing different from what was reviewed and tested.

alternative solution

Use github pull requests. This would solve all of the problems above except: It has an even bigger impact on the workflows.

@ChristianKuehnel
Copy link
Collaborator Author

won't fix because moving towards #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant