Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tidy suggests changes to lldb for a patch that only touches llvm #90

Closed
jayfoad opened this issue Jan 8, 2020 · 3 comments
Closed

clang-tidy suggests changes to lldb for a patch that only touches llvm #90

jayfoad opened this issue Jan 8, 2020 · 3 comments
Assignees
@metaflow
Labels
bug Something isn't working clang-tidy reports around clang-tidy

Comments

@jayfoad
Copy link

jayfoad commented Jan 8, 2020

For this patch, which only touches llvm: https://reviews.llvm.org/D72392
clang-tidy makes these suggestions in lldb: https://results.llvm-merge-guard.org/amd64_debian_testing_clang8-955/clang-tidy.txt
These suggestions seem completely irrelevant to my patch.
@jayfoad jayfoad added the bug Something isn't working label Jan 8, 2020
@joker-eph joker-eph mentioned this issue Jan 13, 2020
Closed
@ChristianKuehnel
Copy link
Collaborator

@metaflow can you please take a look?

@ChristianKuehnel ChristianKuehnel added the clang-tidy reports around clang-tidy label Jan 13, 2020
@metaflow
Copy link
Collaborator

looking into that

@metaflow
Copy link
Collaborator

I have tried this patch with recent changes and it seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metaflow metaflow

Labels
bug Something isn't working clang-tidy reports around clang-tidy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jayfoad @metaflow @ChristianKuehnel