Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Duplicate SplitStringUsing etc. #25

Open
huahang opened this issue Apr 17, 2014 · 2 comments
Open

Duplicate SplitStringUsing etc. #25

huahang opened this issue Apr 17, 2014 · 2 comments

Comments

@huahang
Copy link

huahang commented Apr 17, 2014

The following 2 functions exist in both lmctfy/strings/strutil.cc and lmctfy/strings/split.cc

SplitStringUsing(std::string const&, char const_, std::vector<std::string, std::allocatorstd::string >_)'

SplitStringAllowEmpty(std::string const&, char const_, std::vector<std::string, std::allocatorstd::string >_)

@huahang
Copy link
Author

huahang commented Apr 17, 2014

maybe using namespace to guard these functions?

@vmarmol
Copy link
Contributor

vmarmol commented Apr 17, 2014

It looks like the ones in split.cc are in the strings namespace whereas the ones in strutil are at root. I think strutil should export the ones in split.cc instead, but that will probably require changes in some clients of strutil.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants