Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log/syslog
module has been supporteddarwin
on current Go stable version (1.6).Not ignored
darwin
.https://github.com/golang/go/blob/master/src/log/syslog/syslog.go#L5
If fix
+build linux darwin
forhttps://github.com/google/logger/blob/master/logger_linux.go#L14
,but can not build by the build file structure of Go.
So, I create a new
logger_darwin.go
.If it is not the correct way, please point out.
In addition, If need a sign-off of google to special license(CLA?), I willing to sign.