Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add darwin support #1

Merged
merged 1 commit into from Feb 29, 2016
Merged

Add darwin support #1

merged 1 commit into from Feb 29, 2016

Conversation

zchee
Copy link
Contributor

@zchee zchee commented Feb 27, 2016

log/syslog module has been supported darwin on current Go stable version (1.6).
Not ignored darwin.
https://github.com/golang/go/blob/master/src/log/syslog/syslog.go#L5

If fix +build linux darwin for
https://github.com/google/logger/blob/master/logger_linux.go#L14
,but can not build by the build file structure of Go.

So, I create a new logger_darwin.go.
If it is not the correct way, please point out.

In addition, If need a sign-off of google to special license(CLA?), I willing to sign.

@zchee
Copy link
Contributor Author

zchee commented Feb 27, 2016

BTW, I successful go build, but actual behavior is not tested.
Sorry.

and, If need add Linux and Darwin notes on

, I will also commit.

@adjackura
Copy link
Collaborator

+build linux darwin should work fine if you rename logger_linux.go to logger_syslog.go.

Head over here to sign the CLA:
https://cla.developers.google.com/about/google-individual

@zchee
Copy link
Contributor Author

zchee commented Feb 28, 2016

@adjackura got it.
I will fix and sign later.

@adjackura
Copy link
Collaborator

Don't worry about the CLA, looks like you signed it a year ago.

Signed-off-by: Koichi Shiraishi <k@zchee.io>
@zchee
Copy link
Contributor Author

zchee commented Feb 28, 2016

@adjackura Rename and add darwin for +build flag.
PTAL.

CLA: I got it. Thanks.

adjackura added a commit that referenced this pull request Feb 29, 2016
@adjackura adjackura merged commit 97ba4c7 into google:master Feb 29, 2016
@zchee
Copy link
Contributor Author

zchee commented Mar 3, 2016

@adjackura Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants