Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to make sure the pypi have the --generate-report #4

Closed
ebursztein opened this issue Feb 7, 2024 · 1 comment
Closed

Need to make sure the pypi have the --generate-report #4

ebursztein opened this issue Feb 7, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request P0 High priority bug

Comments

@ebursztein
Copy link
Collaborator

ebursztein commented Feb 7, 2024

It seems the current pypi package doesn't have proper installation ?
Also make sure the package report all the information that we need to debug an false positive and a proper warning. So it should contains:

  • A disclaimer to not report private or sensitive files
  • instruction on how to report -- same as readme + URL on where to report (short link to Google form which must be public for external + email optional if we have question)
  • print information about the version / model / env
  • the raw data we need to create the test files (basically the raw bytes we look at)
  • the model verdict

The pipy version doesn't have the ouput so unsure if all of this is included.

@ebursztein ebursztein added enhancement New feature or request P0 High priority bug labels Feb 7, 2024
@ebursztein ebursztein changed the title Need to implement --report Need to make sure the pypi have the --generate-report Feb 7, 2024
@reyammer
Copy link
Collaborator

reyammer commented Feb 7, 2024

Which pypi version? The one on the public pypi is just a stub from luca, there is no code there.

I've updated the generated report, this is what we have:

  • magika python cli version
  • model name
  • python version
  • for each tested file: the file hash, extracted features, raw model output, score, output of the tool (which may or may not overwrite the model output)

A suffix (and not a prefix, to make sure people see it):

"""
Please copy/paste the above as a description of your issue. Open a GitHub issue or reach out at magika-devs@google.com.
Please include as many details as possible, e.g., what was the expected content type.
IMPORTANT: do NOT submit private information or PII! The extracted features include many bytes of the tested files!
"""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P0 High priority bug
Projects
None yet
Development

No branches or pull requests

2 participants