Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ic_menu_white is in Bitmap mode #154

Closed
hidrodixtion opened this issue Jun 19, 2015 · 11 comments
Closed

ic_menu_white is in Bitmap mode #154

hidrodixtion opened this issue Jun 19, 2015 · 11 comments
Labels

Comments

@hidrodixtion
Copy link

ic_menu_white has black background and turned out it is saved in Bitmap mode, not in Grayscale mode. Thus it doesn't have transparent background.

screen shot 2015-06-19 at 4 52 21 pm

@shyndman
Copy link
Contributor

Can you point to a specific file in the repo so I can take a look?

@hidrodixtion
Copy link
Author

Inside navigation folder, all file with name ic_menu_white_xxdp.png. It shows perfectly when viewed using browser, but when I import it for Android Project, there's black background and when I open it using Photoshop the image mode is in Bitmap, not Grayscale like the others.

I just found out today that there are other files like that :

  • ic_fullscreen_white_xxdp.png
  • ic_fullscreen_exit_white_xxdp.png

@shyndman
Copy link
Contributor

Interesting. I'll take a look.

@shyndman shyndman added the bug label Jun 22, 2015
@shyndman shyndman self-assigned this Jun 22, 2015
@PetrDana
Copy link

Not only this icons, but also i.e. x(x)(x)hdpi ic_add_white_24(36)(48)dp.png has only 1 bit color depth (18dp version is ok).

@jestelle
Copy link
Contributor

jestelle commented Jul 8, 2015

This looks related to issue #137

Can you let us know where you're finding these icons incorrectly rendering? Is it only in Android Studio? Or do you see it in your apps too?

Note this bug against Android Studio: https://code.google.com/p/android/issues/detail?id=178071

@jestelle jestelle assigned jestelle and unassigned shyndman Jul 8, 2015
@hidrodixtion
Copy link
Author

I see it in my apps too not only in Android Studio.

@shyndman
Copy link
Contributor

shyndman commented Jul 8, 2015

We'll take a look. Thanks @hidrodixtion.

@shyndman
Copy link
Contributor

shyndman commented Jul 9, 2015

@hidrodixtion, we haven't been able to reproduce. Would you mind sending us more information about how you're using the icon?

@hidrodixtion
Copy link
Author

I'm using android-drawable-importer-intellij-plugin

This is how it looks like in android studio: (ic_stop_white)
screen shot 2015-07-15 at 9 41 21 am

This is how it looks like in my app: (on floating action button)
screen shot 2015-07-15 at 9 44 24 am

Compared to when I use ic_play_arrow_white:
screen shot 2015-07-15 at 9 45 05 am

@jestelle
Copy link
Contributor

@hidrodixtion You might try copying the files into your project directly, and not using that importer tool.
I'm guessing that tool may be introducing the problem.

@RoelN
Copy link
Collaborator

RoelN commented Feb 23, 2021

The assets have been updated since this issue was reported, so I believe this should be fixed. If not, feel free to reopen this issue or create a new one with more information.

@RoelN RoelN closed this as completed Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants