Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: icons do not follow page ltr/rtl direction #750

Open
clshortfuse opened this issue Mar 22, 2018 · 4 comments
Open

web: icons do not follow page ltr/rtl direction #750

clshortfuse opened this issue Mar 22, 2018 · 4 comments
Assignees
Labels

Comments

@clshortfuse
Copy link

First of all, let me start of by saying, I'm not talking about glyph/icon mirroring.

When a page is using [dir=rtl] items should flow from right to left. Material Design Icons is forcing the orientation to be left to right, even on pages that should be right to left. This forces you to div wrap the icon for the layout to flow properly.

The line in question, specifically, is this one:

Here's the codepen explaining the issue:

https://codepen.io/shortfuse/pen/RMgrOw

You can see the warning icon isn't properly respecting the page's RTL implementation.

I'm not sure why the direction: ltr since no browser actually mirrors the icons. This is even stated in the guide:

By default on the web, icons are not mirrored when the layout direction is mirrored. You need to specifically mirror the appropriate icons when needed.

Perhaps the usage of direction: ltr was misunderstood when the rule was added. If it is fully intentional, there should be a better explanation as to why it has to be used and how to workaround the layout direction issue.

@tphinney
Copy link
Collaborator

Seems like a bug/error, yes.

@tphinney tphinney added CSS and removed question labels Apr 28, 2022
@clshortfuse
Copy link
Author

Still happening on Material Symbols as well.

@GPGPgauravpunetha12
Copy link

@tphinney pls assign me this issue

@tomasdev
Copy link
Collaborator

tomasdev commented Feb 8, 2023

https://developer.mozilla.org/en-US/docs/Web/CSS/direction#values given LTR is the default value, I'd suggest removing it altogether and letting implementors define it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants