Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate best practices for font loading #413

Closed
nicolasgarnier opened this issue Jun 19, 2015 · 4 comments
Closed

Investigate best practices for font loading #413

nicolasgarnier opened this issue Jun 19, 2015 · 4 comments
Labels
in-tracker P1
Milestone
V2 Beta

Comments

@nicolasgarnier
Copy link
Contributor

The Material Design fonts are pretty much required for MDL.
Currently developers need to include it themselves using

<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">

We should include it automatically using an @include in the MDL CSS.
@nicolasgarnier nicolasgarnier added this to the Release V1 milestone Jun 19, 2015
This was referenced Jun 19, 2015
Closed
Merged
@addyosmani
Copy link
Contributor

@import? :)

@nicolasgarnier
Copy link
Contributor Author

That thing yea 😃

@addyosmani addyosmani changed the title Add the MD font by default via an @include in the MDL CSS Add the MD font by default via an @import in the MDL CSS Jun 22, 2015
@Garbee
Copy link
Collaborator

Garbee commented Jun 22, 2015

Isn't @import to be avoided due to performance?

Old post from Sounders. Should run tests on newer browsers to see how things get handled considering 6 years have passed since the post.

Sass currently will not do an import of CSS files or fully qualified paths. It will translate it specifically into an @import within the CSS output.

@sgomes sgomes changed the title Add the MD font by default via an @import in the MDL CSS Investigate best practices for font loading Jul 1, 2016
@sgomes sgomes modified the milestones: V2 Beta, Release V1 Jul 1, 2016
@sgomes sgomes mentioned this issue Jul 1, 2016
Closed
@traviskaufman traviskaufman mentioned this issue Dec 5, 2016
Closed
@sfdexter
Copy link
Collaborator

Superceded by material-components/material-components-web#40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in-tracker P1
Projects
None yet
Milestone
V2 Beta
Development

No branches or pull requests
6 participants
@addyosmani @sgomes @Garbee @traviskaufman @nicolasgarnier @sfdexter